Skip to content

Revert "[flang] Use precompiled parsing headers" #134851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

mrkajetanp
Copy link
Contributor

Reverts #130600

Reverting on account of Windows issues with ccache, will bring back along with #131137 once those are resolved.

@llvmbot llvmbot added flang:driver flang Flang issues not falling into any other category labels Apr 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 8, 2025

@llvm/pr-subscribers-flang-driver

Author: Kajetan Puchalski (mrkajetanp)

Changes

Reverts llvm/llvm-project#130600

Reverting on account of Windows issues with ccache, will bring back along with #131137 once those are resolved.


Full diff: https://github.com/llvm/llvm-project/pull/134851.diff

1 Files Affected:

  • (modified) flang/lib/Frontend/CMakeLists.txt (-8)
diff --git a/flang/lib/Frontend/CMakeLists.txt b/flang/lib/Frontend/CMakeLists.txt
index e8a098613e26f..c80373799b015 100644
--- a/flang/lib/Frontend/CMakeLists.txt
+++ b/flang/lib/Frontend/CMakeLists.txt
@@ -72,11 +72,3 @@ add_flang_library(flangFrontend
   clangBasic
   clangDriver
 )
-
-target_precompile_headers(flangFrontend PRIVATE
-  [["flang/Parser/parsing.h"]]
-  [["flang/Parser/parse-tree.h"]]
-  [["flang/Parser/dump-parse-tree.h"]]
-  [["flang/Lower/PFTBuilder.h"]]
-  [["flang/Lower/Bridge.h"]]
-)

@mrkajetanp mrkajetanp merged commit 7e1b76c into main Apr 8, 2025
9 of 13 checks passed
@mrkajetanp mrkajetanp deleted the revert-130600-precompiled-headers branch April 8, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:driver flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants