Skip to content

Conversation

lntue
Copy link
Contributor

@lntue lntue commented Apr 8, 2025

This test is currently failing on aarch64 build bots.

@llvmbot llvmbot added the libc label Apr 8, 2025
@lntue lntue requested a review from jhuber6 April 8, 2025 17:34
@llvmbot
Copy link
Member

llvmbot commented Apr 8, 2025

@llvm/pr-subscribers-libc

Author: None (lntue)

Changes

This test is currently failing on aarch64 build bots.


Full diff: https://github.com/llvm/llvm-project/pull/134891.diff

1 Files Affected:

  • (modified) libc/test/src/math/smoke/sinpif16_test.cpp (+5-1)
diff --git a/libc/test/src/math/smoke/sinpif16_test.cpp b/libc/test/src/math/smoke/sinpif16_test.cpp
index b2db6fb9f8626..f6d395bd0f2c0 100644
--- a/libc/test/src/math/smoke/sinpif16_test.cpp
+++ b/libc/test/src/math/smoke/sinpif16_test.cpp
@@ -17,7 +17,11 @@ using LlvmLibcSinpif16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
 TEST_F(LlvmLibcSinpif16Test, SpecialNumbers) {
   LIBC_NAMESPACE::libc_errno = 0;
 
-  EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::sinpif16(sNaN), FE_INVALID);
+  // TODO: This floating point exception test was failing on aarch64 build bot.
+  // Investigate and re-enable it.
+  // EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::sinpif16(sNaN),
+  // FE_INVALID);
+  EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(sNaN));
   EXPECT_MATH_ERRNO(0);
 
   EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::sinpif16(aNaN));

@lntue
Copy link
Contributor Author

lntue commented Apr 8, 2025

#134918 instead

@lntue lntue closed this Apr 8, 2025
@lntue lntue deleted the sinpif16 branch July 18, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants