Skip to content

ELF: Remove lock from MTE global relocation handling code. #135123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

ELF: Remove lock from MTE global relocation handling code. #135123

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d91c48
[𝘀𝗽𝗿] changes to main this commit is based on
pcc Apr 10, 2025
447585a
[𝘀𝗽𝗿] initial version
pcc Apr 10, 2025
99a6ada
[𝘀𝗽𝗿] changes introduced through rebase
pcc Apr 10, 2025
858f3c1
Rebase
pcc Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lld/ELF/Relocations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,9 +847,8 @@ static void addRelativeReloc(Ctx &ctx, InputSectionBase &isec,
Partition &part = isec.getPartition(ctx);

if (sym.isTagged()) {
std::lock_guard<std::mutex> lock(ctx.relocMutex);
part.relaDyn->addRelativeReloc(ctx.target->relativeRel, isec, offsetInSec,
sym, addend, type, expr);
part.relaDyn->addRelativeReloc<shard>(ctx.target->relativeRel, isec,
offsetInSec, sym, addend, type, expr);
// With MTE globals, we always want to derive the address tag by `ldg`-ing
// the symbol. When we have a RELATIVE relocation though, we no longer have
// a reference to the symbol. Because of this, when we have an addend that
Expand Down
Loading