Skip to content

Conversation

Chengjunp
Copy link
Contributor

@Chengjunp Chengjunp commented May 7, 2025

Fix the failed test in the PR by moving the test to CodeGen/NVPTX.

@Chengjunp Chengjunp self-assigned this May 7, 2025
@Chengjunp Chengjunp requested a review from Prince781 May 7, 2025 23:44
@llvmbot llvmbot added backend:NVPTX llvm:analysis Includes value tracking, cost tables and constant folding labels May 7, 2025
@Chengjunp Chengjunp requested a review from AlexMaclean May 7, 2025 23:44
@llvmbot
Copy link
Member

llvmbot commented May 7, 2025

@llvm/pr-subscribers-backend-nvptx

@llvm/pr-subscribers-llvm-analysis

Author: Chengjun (Chengjunp)

Changes

Fix the failed test in the PR by adding the REQUIRES for nvptx-registered-target.


Full diff: https://github.com/llvm/llvm-project/pull/138992.diff

1 Files Affected:

  • (modified) llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll (+1-1)
diff --git a/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll b/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
index 0d16b344e9f66..d43ab29a14cef 100644
--- a/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
+++ b/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
@@ -1,4 +1,4 @@
-; REQUIRES: asserts
+; REQUIRES: asserts, nvptx-registered-target
 ; RUN: opt -aa-pipeline=default -passes='require<aa>' -debug-pass-manager -disable-output -S < %s 2>&1 | FileCheck %s
 ; RUN: llc --debug-only='aa' -o /dev/null %s 2>&1 | FileCheck %s -check-prefix=LEGACY
 

@AlexMaclean
Copy link
Member

I don't see any other target-specific analyses in llvm/test/Analysis. Maybe we should move this test to llvm/test/CodeGen/NVPTX?

Copy link
Member

@AlexMaclean AlexMaclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengjunp Chengjunp merged commit 934cfa7 into llvm:main May 7, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:NVPTX llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants