[mlir][tosa] Fix indexing in TosaToTensor

[shay-kl]

Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.

[llvmbot]

@llvm/pr-subscribers-mlir-tosa

Author: Shay Kleiman (shay-kl)

Changes

Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.

---

Full diff: https://github.com/llvm/llvm-project/pull/140903.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp (+1-1)

diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index 5f23a33049f87..6c68a7fc25103 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -362,7 +362,7 @@ class PadConverter : public OpConversionPattern<tosa::PadOp> {
     // Setup the default constantAttr.
 
     Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
-        loc, padOp.getPadConst(), ValueRange({}));
+      loc, padOp.getPadConst(), ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
 
     if (!padConstant) {
       return rewriter.notifyMatchFailure(

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Shay Kleiman (shay-kl)

Changes

Changed the indexing used in the extractOp from one that is intended for 0d tensors to one that is intended for 1d tensors.

---

Full diff: https://github.com/llvm/llvm-project/pull/140903.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp (+1-1)

diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index 5f23a33049f87..6c68a7fc25103 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -362,7 +362,7 @@ class PadConverter : public OpConversionPattern<tosa::PadOp> {
     // Setup the default constantAttr.
 
     Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
-        loc, padOp.getPadConst(), ValueRange({}));
+      loc, padOp.getPadConst(), ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
 
     if (!padConstant) {
       return rewriter.notifyMatchFailure(

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff HEAD~1 HEAD --extensions cpp -- mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp

View the diff from clang-format here.

diff --git a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
index 6c68a7fc2..615c7ca1c 100644
--- a/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
+++ b/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp
@@ -362,7 +362,8 @@ public:
     // Setup the default constantAttr.
 
     Value padConstant = rewriter.createOrFold<tensor::ExtractOp>(
-      loc, padOp.getPadConst(), ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
+        loc, padOp.getPadConst(),
+        ValueRange({rewriter.create<arith::ConstantIndexOp>(loc, 0)}));
 
     if (!padConstant) {
       return rewriter.notifyMatchFailure(