[llvm-cgdata] Fix Dangling StringRefs #143210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OutputFilename` and `Filename` are assigned to StringRefs in `parseArgs`, but after `parseArgs` returns the `InputArgsList` that once owned the underlying strings is popped off the stack, and the StringRefs can be left pointing at garbage. Switch to std::string to own the strings.
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutputFilenameandFilenameare assigned to StringRefs inparseArgs, but afterparseArgsreturns theInputArgsListthat once owned the underlying strings is popped off the stack, and the StringRefs can be left pointing at garbage.Switch to std::string to own the strings.