Inject compilation command into __cli_<file> global variable #144622

Pavithra029 · 2025-06-18T00:48:15Z

No description provided.

github-actions · 2025-06-18T00:48:35Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvmbot · 2025-06-18T00:49:03Z

@llvm/pr-subscribers-clang

Author: None (Pavithra029)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/144622.diff

1 Files Affected:

(modified) clang/lib/CodeGen/CodeGenModule.cpp (+100)

diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index c005d3322ed7a..577cb6f0abd2c 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -1472,6 +1472,106 @@ void CodeGenModule::Release() {
       }
     }
   }
+  
+      // 1. Get source file name
+  /*  std::string FileName = getModule().getSourceFileName(); // like "foo.c"
+    llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
+
+    // 2. Create variable name like __cli_foo_c
+    std::string VarName = "__cli_" + BaseName.str();
+    std::replace(VarName.begin(), VarName.end(), '.', '_');
+
+    // 3. Get the compilation command line from options
+    std::string CmdLineStr;
+    for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
+        CmdLineStr += Arg + " ";
+    }
+
+    // 4. Create LLVM IR string global
+    llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+    // 1. Prepare internal string global variable
+auto *GV = new llvm::GlobalVariable(
+    getModule(),
+    CmdStr->getType(),
+    true,
+    llvm::GlobalValue::InternalLinkage,
+    CmdStr,
+    VarName + ".data"
+);
+GV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+
+// 2. Create external pointer global pointing to internal string
+llvm::Constant *Zero = llvm::ConstantInt::get(llvm::Type::getInt32Ty(getLLVMContext()), 0);
+llvm::Constant *Indices[] = {Zero, Zero};
+llvm::Constant *PtrToStr = llvm::ConstantExpr::getGetElementPtr(CmdStr->getType(), GV, Indices);
+
+auto *ExternGV = new llvm::GlobalVariable(
+    getModule(),
+    PtrToStr->getType(),
+    true,
+    llvm::GlobalValue::ExternalLinkage,
+    PtrToStr,
+    VarName
+);
+ExternGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+(void)ExternGV;
+    llvm::errs() << "✅ Emitting __cli global variable!\n";
+
+  */
+  
+  // === BEGIN: Emit global __cli_<file> variable ===
+
+std::string FileName = getModule().getSourceFileName();
+llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
+std::string VarName = "__cli_" + BaseName.str();
+std::replace(VarName.begin(), VarName.end(), '.', '_');
+
+// Join command line args into one string
+std::string CmdLineStr;
+for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
+    CmdLineStr += Arg + " ";
+}
+
+// Step 1: Create string constant (char[] data)
+llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+
+// Step 2: Emit internal variable: @__cli_foo_c.data
+auto *DataGV = new llvm::GlobalVariable(
+    getModule(),
+    CmdStr->getType(),                         // [N x i8]
+    true,                                     // constant
+    llvm::GlobalValue::InternalLinkage,
+    CmdStr,
+    VarName + ".data"
+);
+DataGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+
+// Step 3: Pointer to string
+llvm::Constant *PtrToStr = llvm::ConstantExpr::getPointerCast(
+    DataGV, llvm::PointerType::getUnqual(llvm::Type::getInt8Ty(getLLVMContext()))
+);
+
+
+// Step 4: Remove dummy external if exists
+if (auto *Old = getModule().getNamedGlobal(VarName)) {
+    Old->eraseFromParent();
+}
+
+// ✅ Step 5: Emit the real global variable
+auto *FinalGV = new llvm::GlobalVariable(
+    getModule(),
+    PtrToStr->getType(),                       // i8*
+    true,                                     // constant
+    llvm::GlobalValue::ExternalLinkage,       // important: this makes it visible!
+    PtrToStr,
+    VarName
+);
+//FinalGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+
+llvm::errs() << "✅ Emitting " << VarName << " global variable!\n";
+
+// === END ===
+
 }
 
 void CodeGenModule::EmitOpenCLMetadata() {

llvmbot · 2025-06-18T00:49:03Z

@llvm/pr-subscribers-clang-codegen

Author: None (Pavithra029)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/144622.diff

1 Files Affected:

(modified) clang/lib/CodeGen/CodeGenModule.cpp (+100)

diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index c005d3322ed7a..577cb6f0abd2c 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -1472,6 +1472,106 @@ void CodeGenModule::Release() {
       }
     }
   }
+  
+      // 1. Get source file name
+  /*  std::string FileName = getModule().getSourceFileName(); // like "foo.c"
+    llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
+
+    // 2. Create variable name like __cli_foo_c
+    std::string VarName = "__cli_" + BaseName.str();
+    std::replace(VarName.begin(), VarName.end(), '.', '_');
+
+    // 3. Get the compilation command line from options
+    std::string CmdLineStr;
+    for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
+        CmdLineStr += Arg + " ";
+    }
+
+    // 4. Create LLVM IR string global
+    llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+    // 1. Prepare internal string global variable
+auto *GV = new llvm::GlobalVariable(
+    getModule(),
+    CmdStr->getType(),
+    true,
+    llvm::GlobalValue::InternalLinkage,
+    CmdStr,
+    VarName + ".data"
+);
+GV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+
+// 2. Create external pointer global pointing to internal string
+llvm::Constant *Zero = llvm::ConstantInt::get(llvm::Type::getInt32Ty(getLLVMContext()), 0);
+llvm::Constant *Indices[] = {Zero, Zero};
+llvm::Constant *PtrToStr = llvm::ConstantExpr::getGetElementPtr(CmdStr->getType(), GV, Indices);
+
+auto *ExternGV = new llvm::GlobalVariable(
+    getModule(),
+    PtrToStr->getType(),
+    true,
+    llvm::GlobalValue::ExternalLinkage,
+    PtrToStr,
+    VarName
+);
+ExternGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+(void)ExternGV;
+    llvm::errs() << "✅ Emitting __cli global variable!\n";
+
+  */
+  
+  // === BEGIN: Emit global __cli_<file> variable ===
+
+std::string FileName = getModule().getSourceFileName();
+llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
+std::string VarName = "__cli_" + BaseName.str();
+std::replace(VarName.begin(), VarName.end(), '.', '_');
+
+// Join command line args into one string
+std::string CmdLineStr;
+for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
+    CmdLineStr += Arg + " ";
+}
+
+// Step 1: Create string constant (char[] data)
+llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+
+// Step 2: Emit internal variable: @__cli_foo_c.data
+auto *DataGV = new llvm::GlobalVariable(
+    getModule(),
+    CmdStr->getType(),                         // [N x i8]
+    true,                                     // constant
+    llvm::GlobalValue::InternalLinkage,
+    CmdStr,
+    VarName + ".data"
+);
+DataGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+
+// Step 3: Pointer to string
+llvm::Constant *PtrToStr = llvm::ConstantExpr::getPointerCast(
+    DataGV, llvm::PointerType::getUnqual(llvm::Type::getInt8Ty(getLLVMContext()))
+);
+
+
+// Step 4: Remove dummy external if exists
+if (auto *Old = getModule().getNamedGlobal(VarName)) {
+    Old->eraseFromParent();
+}
+
+// ✅ Step 5: Emit the real global variable
+auto *FinalGV = new llvm::GlobalVariable(
+    getModule(),
+    PtrToStr->getType(),                       // i8*
+    true,                                     // constant
+    llvm::GlobalValue::ExternalLinkage,       // important: this makes it visible!
+    PtrToStr,
+    VarName
+);
+//FinalGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+
+llvm::errs() << "✅ Emitting " << VarName << " global variable!\n";
+
+// === END ===
+
 }
 
 void CodeGenModule::EmitOpenCLMetadata() {

github-actions · 2025-06-18T13:37:58Z

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/CodeGen/CodeGenModule.cpp

View the diff from clang-format here.

diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index e3efbc275..b55025ada 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -1479,8 +1479,8 @@ void CodeGenModule::Release() {
       }
     }
   }
-  
-      // 1. Get source file name
+
+  // 1. Get source file name
   /*  std::string FileName = getModule().getSourceFileName(); // like "foo.c"
     llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
 
@@ -1495,7 +1495,8 @@ void CodeGenModule::Release() {
     }
 
     // 4. Create LLVM IR string global
-    llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+    llvm::Constant *CmdStr =
+llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
     // 1. Prepare internal string global variable
 auto *GV = new llvm::GlobalVariable(
     getModule(),
@@ -1508,9 +1509,11 @@ auto *GV = new llvm::GlobalVariable(
 GV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
 
 // 2. Create external pointer global pointing to internal string
-llvm::Constant *Zero = llvm::ConstantInt::get(llvm::Type::getInt32Ty(getLLVMContext()), 0);
+llvm::Constant *Zero =
+llvm::ConstantInt::get(llvm::Type::getInt32Ty(getLLVMContext()), 0);
 llvm::Constant *Indices[] = {Zero, Zero};
-llvm::Constant *PtrToStr = llvm::ConstantExpr::getGetElementPtr(CmdStr->getType(), GV, Indices);
+llvm::Constant *PtrToStr =
+llvm::ConstantExpr::getGetElementPtr(CmdStr->getType(), GV, Indices);
 
 auto *ExternGV = new llvm::GlobalVariable(
     getModule(),
@@ -1525,60 +1528,54 @@ ExternGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
     llvm::errs() << "✅ Emitting __cli global variable!\n";
 
   */
-  
+
   // === BEGIN: Emit global __cli_<file> variable ===
 
-std::string FileName = getModule().getSourceFileName();
-llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
-std::string VarName = "__cli_" + BaseName.str();
-std::replace(VarName.begin(), VarName.end(), '.', '_');
+  std::string FileName = getModule().getSourceFileName();
+  llvm::StringRef BaseName = llvm::sys::path::filename(FileName);
+  std::string VarName = "__cli_" + BaseName.str();
+  std::replace(VarName.begin(), VarName.end(), '.', '_');
 
-// Join command line args into one string
-std::string CmdLineStr;
-for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
+  // Join command line args into one string
+  std::string CmdLineStr;
+  for (const std::string &Arg : CodeGenOpts.CommandLineArgs) {
     CmdLineStr += Arg + " ";
-}
-
-// Step 1: Create string constant (char[] data)
-llvm::Constant *CmdStr = llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
+  }
 
-// Step 2: Emit internal variable: @__cli_foo_c.data
-auto *DataGV = new llvm::GlobalVariable(
-    getModule(),
-    CmdStr->getType(),                         // [N x i8]
-    true,                                     // constant
-    llvm::GlobalValue::InternalLinkage,
-    CmdStr,
-    VarName + ".data"
-);
-DataGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+  // Step 1: Create string constant (char[] data)
+  llvm::Constant *CmdStr =
+      llvm::ConstantDataArray::getString(getLLVMContext(), CmdLineStr, true);
 
-// Step 3: Pointer to string
-llvm::Constant *PtrToStr = llvm::ConstantExpr::getPointerCast(
-    DataGV, llvm::PointerType::getUnqual(llvm::Type::getInt8Ty(getLLVMContext()))
-);
+  // Step 2: Emit internal variable: @__cli_foo_c.data
+  auto *DataGV = new llvm::GlobalVariable(getModule(),
+                                          CmdStr->getType(), // [N x i8]
+                                          true,              // constant
+                                          llvm::GlobalValue::InternalLinkage,
+                                          CmdStr, VarName + ".data");
+  DataGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
 
+  // Step 3: Pointer to string
+  llvm::Constant *PtrToStr = llvm::ConstantExpr::getPointerCast(
+      DataGV,
+      llvm::PointerType::getUnqual(llvm::Type::getInt8Ty(getLLVMContext())));
 
-// Step 4: Remove dummy external if exists
-if (auto *Old = getModule().getNamedGlobal(VarName)) {
+  // Step 4: Remove dummy external if exists
+  if (auto *Old = getModule().getNamedGlobal(VarName)) {
     Old->eraseFromParent();
-}
-
-// ✅ Step 5: Emit the real global variable
-auto *FinalGV = new llvm::GlobalVariable(
-    getModule(),
-    PtrToStr->getType(),                       // i8*
-    true,                                     // constant
-    llvm::GlobalValue::ExternalLinkage,       // important: this makes it visible!
-    PtrToStr,
-    VarName
-);
-//FinalGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
+  }
 
-llvm::errs() << "✅ Emitting " << VarName << " global variable!\n";
+  // ✅ Step 5: Emit the real global variable
+  auto *FinalGV = new llvm::GlobalVariable(
+      getModule(),
+      PtrToStr->getType(),                // i8*
+      true,                               // constant
+      llvm::GlobalValue::ExternalLinkage, // important: this makes it visible!
+      PtrToStr, VarName);
+  // FinalGV->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);
 
-// === END ===
+  llvm::errs() << "✅ Emitting " << VarName << " global variable!\n";
 
+  // === END ===
 }
 
 void CodeGenModule::EmitOpenCLMetadata() {

efriedma-quic · 2025-06-18T16:36:07Z

Please start a thread on https://discourse.llvm.org/ describing the problem you're trying to solve, and your proposed solution.

Record compilation command line

zwuis · 2025-06-20T15:33:45Z

You should fork https://github.com/Ritanya-B-Bharadwaj/llvm-project and create Pull Request there.

Inject compilation command into __cli_<file> global variable

d41ac68

llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels Jun 18, 2025

zwuis mentioned this pull request Jun 19, 2025

Dump auto (c++11) type Inferences (Issue #17) #144478

Closed

pavithra and others added 2 commits June 20, 2025 19:24

Fix: Inject __cli_<file> global variable with command line

666c6f4

Merge pull request #1 from Ritanya-B-Bharadwaj/main

fbdacc3

Record compilation command line

Merge branch 'main' into cli-injection-feature

83be53c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Inject compilation command into __cli_<file> global variable #144622

Inject compilation command into __cli_<file> global variable #144622

Uh oh!

Pavithra029 commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

llvmbot commented Jun 18, 2025

Uh oh!

llvmbot commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

efriedma-quic commented Jun 18, 2025

Uh oh!

zwuis commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Inject compilation command into __cli_<file> global variable #144622

Are you sure you want to change the base?

Inject compilation command into __cli_<file> global variable #144622

Uh oh!

Conversation

Pavithra029 commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

llvmbot commented Jun 18, 2025

Uh oh!

llvmbot commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

efriedma-quic commented Jun 18, 2025

Uh oh!

zwuis commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants