Skip to content

[lldb] Eliminate check for HasLoadedSections (NFC) #145366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

[lldb] Eliminate check for HasLoadedSections (NFC) #145366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df38e3
[lldb] Eliminate check for HasLoadedSections (NFC)
JDevlieghere Jun 23, 2025
426809d
Merge branch 'main' into DumpAddressAndContent
JDevlieghere Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lldb/source/Core/FormatEntity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,7 @@ static bool DumpAddressAndContent(Stream &s, const SymbolContext *sc,
bool print_file_addr_or_load_addr) {
Target *target = Target::GetTargetFromContexts(exe_ctx, sc);

addr_t vaddr = LLDB_INVALID_ADDRESS;
if (target && target->HasLoadedSections())
vaddr = addr.GetLoadAddress(target);
addr_t vaddr = addr.GetLoadAddress(target);
if (vaddr == LLDB_INVALID_ADDRESS)
vaddr = addr.GetFileAddress();
if (vaddr == LLDB_INVALID_ADDRESS)
Expand Down
Loading