Skip to content

[clang-doc] Precommit friends test - #146164

Merged
evelez7 merged 1 commit into
mainfrom
users/evelez7/clang-doc-precommit-friends
Jun 30, 2025
Merged

[clang-doc] Precommit friends test#146164
evelez7 merged 1 commit into
mainfrom
users/evelez7/clang-doc-precommit-friends

Conversation

@evelez7

@evelez7 evelez7 commented Jun 27, 2025

Copy link
Copy Markdown
Member

No description provided.

evelez7 commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

Base automatically changed from users/evelez7/clang-doc-fix-types to main June 27, 2025 23:17
@evelez7
evelez7 force-pushed the users/evelez7/clang-doc-precommit-friends branch from bf66a99 to 111fe87 Compare June 27, 2025 23:19
@evelez7
evelez7 marked this pull request as ready for review June 30, 2025 16:50
@llvmbot

llvmbot commented Jun 30, 2025

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-clang-tools-extra

Author: Erick Velez (evelez7)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/146164.diff

1 Files Affected:

  • (modified) clang-tools-extra/test/clang-doc/json/class.cpp (+41)
diff --git a/clang-tools-extra/test/clang-doc/json/class.cpp b/clang-tools-extra/test/clang-doc/json/class.cpp
index bd82b8159e2f9..0715fcefbb785 100644
--- a/clang-tools-extra/test/clang-doc/json/class.cpp
+++ b/clang-tools-extra/test/clang-doc/json/class.cpp
@@ -23,6 +23,9 @@ struct MyClass {
   typedef int MyTypedef;
   
   class NestedClass;
+  
+  friend struct Foo;
+  template<typename T> friend void friendFunction(int);
 protected:
   int protectedMethod();
 
@@ -86,6 +89,44 @@ struct MyClass {
 // CHECK-NEXT:        "USR": "{{[0-9A-F]*}}"
 // CHECK-NEXT:      }
 // CHECK-NEXT:    ],
+// CHECK-NOT:     "Friends": [
+// CHECK-NOT:       {
+// CHECK-NOT:         "IsClass": false,
+// CHECK-NOT:         "Params": [
+// CHECK-NOT:           {
+// CHECK-NOT:             "Name": "",
+// CHECK-NOT:             "Type": "int"
+// CHECK-NOT:           }
+// CHECK-NOT:         ],
+// CHECK-NOT:         "Reference": {
+// CHECK-NOT:           "Name": "friendFunction",
+// CHECK-NOT:           "Path": "",
+// CHECK-NOT:           "QualName": "friendFunction",
+// CHECK-NOT:           "USR": "{{[0-9A-F]*}}"
+// CHECK-NOT:         },
+// CHECK-NOT:         "ReturnType": {
+// CHECK-NOT:           "IsBuiltIn": true,
+// CHECK-NOT:           "IsTemplate": false,
+// CHECK-NOT:           "Name": "void",
+// CHECK-NOT:           "QualName": "void",
+// CHECK-NOT:           "USR": "0000000000000000000000000000000000000000"
+// CHECK-NOT:         },
+// CHECK-NOT:         "Template": {
+// CHECK-NOT:           "Parameters": [
+// CHECK-NOT:             "typename T"
+// CHECK-NOT:           ]
+// CHECK-NOT:         }
+// CHECK-NOT:       },
+// CHECK-NOT:       {
+// CHECK-NOT:         "IsClass": true,
+// CHECK-NOT:         "Reference": {
+// CHECK-NOT:           "Name": "Foo",
+// CHECK-NOT:           "Path": "GlobalNamespace",
+// CHECK-NOT:           "QualName": "Foo",
+// CHECK-NOT:           "USR": "{{[0-9A-F]*}}"
+// CHECK-NOT:         },
+// CHECK-NOT:       },
+// CHECK-NOT:    ],
 // COM:           FIXME: FullName is not emitted correctly.
 // CHECK-NEXT:    "FullName": "",
 // CHECK-NEXT:    "IsTypedef": false,

@evelez7
evelez7 force-pushed the users/evelez7/clang-doc-precommit-friends branch from 111fe87 to 41027d6 Compare June 30, 2025 18:10

evelez7 commented Jun 30, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Jun 30, 6:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 30, 6:47 PM UTC: @evelez7 merged this pull request with Graphite.

@evelez7
evelez7 merged commit ba84d0c into main Jun 30, 2025
7 checks passed
@evelez7
evelez7 deleted the users/evelez7/clang-doc-precommit-friends branch June 30, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants