[clang-doc] Precommit friends test - #146164
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 27, 2025
ilovepi
approved these changes
Jun 27, 2025
evelez7
force-pushed
the
users/evelez7/clang-doc-precommit-friends
branch
from
June 27, 2025 23:19
bf66a99 to
111fe87
Compare
evelez7
marked this pull request as ready for review
June 30, 2025 16:50
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) ChangesFull diff: https://github.com/llvm/llvm-project/pull/146164.diff 1 Files Affected:
diff --git a/clang-tools-extra/test/clang-doc/json/class.cpp b/clang-tools-extra/test/clang-doc/json/class.cpp
index bd82b8159e2f9..0715fcefbb785 100644
--- a/clang-tools-extra/test/clang-doc/json/class.cpp
+++ b/clang-tools-extra/test/clang-doc/json/class.cpp
@@ -23,6 +23,9 @@ struct MyClass {
typedef int MyTypedef;
class NestedClass;
+
+ friend struct Foo;
+ template<typename T> friend void friendFunction(int);
protected:
int protectedMethod();
@@ -86,6 +89,44 @@ struct MyClass {
// CHECK-NEXT: "USR": "{{[0-9A-F]*}}"
// CHECK-NEXT: }
// CHECK-NEXT: ],
+// CHECK-NOT: "Friends": [
+// CHECK-NOT: {
+// CHECK-NOT: "IsClass": false,
+// CHECK-NOT: "Params": [
+// CHECK-NOT: {
+// CHECK-NOT: "Name": "",
+// CHECK-NOT: "Type": "int"
+// CHECK-NOT: }
+// CHECK-NOT: ],
+// CHECK-NOT: "Reference": {
+// CHECK-NOT: "Name": "friendFunction",
+// CHECK-NOT: "Path": "",
+// CHECK-NOT: "QualName": "friendFunction",
+// CHECK-NOT: "USR": "{{[0-9A-F]*}}"
+// CHECK-NOT: },
+// CHECK-NOT: "ReturnType": {
+// CHECK-NOT: "IsBuiltIn": true,
+// CHECK-NOT: "IsTemplate": false,
+// CHECK-NOT: "Name": "void",
+// CHECK-NOT: "QualName": "void",
+// CHECK-NOT: "USR": "0000000000000000000000000000000000000000"
+// CHECK-NOT: },
+// CHECK-NOT: "Template": {
+// CHECK-NOT: "Parameters": [
+// CHECK-NOT: "typename T"
+// CHECK-NOT: ]
+// CHECK-NOT: }
+// CHECK-NOT: },
+// CHECK-NOT: {
+// CHECK-NOT: "IsClass": true,
+// CHECK-NOT: "Reference": {
+// CHECK-NOT: "Name": "Foo",
+// CHECK-NOT: "Path": "GlobalNamespace",
+// CHECK-NOT: "QualName": "Foo",
+// CHECK-NOT: "USR": "{{[0-9A-F]*}}"
+// CHECK-NOT: },
+// CHECK-NOT: },
+// CHECK-NOT: ],
// COM: FIXME: FullName is not emitted correctly.
// CHECK-NEXT: "FullName": "",
// CHECK-NEXT: "IsTypedef": false,
|
evelez7
force-pushed
the
users/evelez7/clang-doc-precommit-friends
branch
from
June 30, 2025 18:10
111fe87 to
41027d6
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.