Skip to content

[mlir][tblgen] Fix test definition names to reflect expected valid results (NFC) #146243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

[mlir][tblgen] Fix test definition names to reflect expected valid results (NFC) #146243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/test/mlir-tblgen/op-format-spec.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def DirectiveRegionsValid : TestFormat_Op<[{
//===----------------------------------------------------------------------===//

// CHECK-NOT: error:
def DirectiveResultsInvalidA : TestFormat_Op<[{
def DirectiveResultsValid : TestFormat_Op<[{
type(results) attr-dict
}]>;

Expand All @@ -104,7 +104,7 @@ def DirectiveResultsInvalidA : TestFormat_Op<[{
//===----------------------------------------------------------------------===//

// CHECK-NOT: error:
def DirectiveSuccessorsInvalidA : TestFormat_Op<[{
def DirectiveSuccessorsValid : TestFormat_Op<[{
successors attr-dict
}]>;

Expand Down Expand Up @@ -167,7 +167,7 @@ def OptionalValidA : TestFormat_Op<[{
//===----------------------------------------------------------------------===//

// CHECK-NOT: error
def StringInvalidA : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;
def StringValid : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;

//===----------------------------------------------------------------------===//
// Variables
Expand Down
Loading