Skip to content

Conversation

tonykuttai
Copy link
Contributor

Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggested changes.

@hubert-reinterpretcast hubert-reinterpretcast marked this pull request as ready for review July 8, 2025 21:08
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Jul 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 8, 2025

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Tony Varghese (tonykuttai)

Changes

This is a followup on the [PowerPC][clang] Fix triple constructor ambiguity causing "unknown" target triple on AIX to address the post-commit review comment.


Full diff: https://github.com/llvm/llvm-project/pull/147584.diff

1 Files Affected:

  • (modified) clang/test/Driver/aix-default-target-triple.c (+1)
diff --git a/clang/test/Driver/aix-default-target-triple.c b/clang/test/Driver/aix-default-target-triple.c
index afad278de78d0..e08cfaf97d349 100644
--- a/clang/test/Driver/aix-default-target-triple.c
+++ b/clang/test/Driver/aix-default-target-triple.c
@@ -3,6 +3,7 @@
 // and doesn't fall back to "unknown" due to constructor ambiguity.
 
 // REQUIRES: system-aix
+// SUPPORTED: target={{.*}}-aix{{.*}}
 // RUN: %clang -v %s -c 2>&1 | FileCheck %s --check-prefix=CHECK-TARGET
 
 // Test that the target triple contains AIX and is not "unknown"

Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming LGTM; thanks!

@tonykuttai tonykuttai merged commit 755b8f9 into llvm:main Jul 9, 2025
9 checks passed
@tonykuttai tonykuttai deleted the tvarghese/targettriplefix branch July 21, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants