Skip to content

[BOLT] Invoke terminator #148333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: users/aaupov/spr/main.bolt-invoke-terminator
Choose a base branch
from

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Jul 12, 2025

Split basic blocks by invoke instructions.

Benefits of switching to an explicit representation of EH control flow:

  • Stale profile matching: need to construct sink block + add edges to it from exit blocks because an exit block may have an invoke with a LP.
  • Dominance analysis is done on per-instruction basis because of LP edges. <- fixing this could reduce time/mem overhead of dominance analysis and its users.
  • Function splitting and block reordering: if continuation/fallthrough is large and cold, it could be outlined.

As a follow-up, LP edges should be added to CFG.

FIXME: this breaks compatibility with old profiles.

Created using spr 1.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant