-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[CIR][NFC] Fix LoweringPrepare pass multi lines summary #148826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) ChangesFix the Lowering Prepare a multi-line summary Full diff: https://github.com/llvm/llvm-project/pull/148826.diff 1 Files Affected:
diff --git a/clang/include/clang/CIR/Dialect/Passes.td b/clang/include/clang/CIR/Dialect/Passes.td
index 65eb857035224..7d5ec2ffed39d 100644
--- a/clang/include/clang/CIR/Dialect/Passes.td
+++ b/clang/include/clang/CIR/Dialect/Passes.td
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> {
}
def LoweringPrepare : Pass<"cir-lowering-prepare"> {
- let summary = "Lower to more fine-grained CIR operations before lowering to
- other dialects";
+ let summary = "Lower to more fine-grained CIR operations before lowering to "
+ "other dialects";
let description = [{
This pass does preparation work for lowering to other dialects. For example,
it may expand the global variable initialziation in a more ABI-friendly form.
|
@llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) ChangesFix the Lowering Prepare a multi-line summary Full diff: https://github.com/llvm/llvm-project/pull/148826.diff 1 Files Affected:
diff --git a/clang/include/clang/CIR/Dialect/Passes.td b/clang/include/clang/CIR/Dialect/Passes.td
index 65eb857035224..7d5ec2ffed39d 100644
--- a/clang/include/clang/CIR/Dialect/Passes.td
+++ b/clang/include/clang/CIR/Dialect/Passes.td
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> {
}
def LoweringPrepare : Pass<"cir-lowering-prepare"> {
- let summary = "Lower to more fine-grained CIR operations before lowering to
- other dialects";
+ let summary = "Lower to more fine-grained CIR operations before lowering to "
+ "other dialects";
let description = [{
This pass does preparation work for lowering to other dialects. For example,
it may expand the global variable initialziation in a more ABI-friendly form.
|
I will quickly merge to make it buildable again |
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> { | |||
} | |||
|
|||
def LoweringPrepare : Pass<"cir-lowering-prepare"> { | |||
let summary = "Lower to more fine-grained CIR operations before lowering to | |||
other dialects"; | |||
let summary = "Lower to more fine-grained CIR operations before lowering to " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this is used, but it may be better to shorten it a bit. Perhaps "Prepare to lower CIR to other dialects"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only one I found is here: mlir/include/mlir/Dialect/Func/TransformOps/FuncTransformOps.td
Yes, I think the summary can be shorter, I will do it with next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andykaylor it is used to generate docs and probably help. See: https://llvm.github.io/clangir/Dialect/passes.html#-cir-lowering-prepare
Fix the Lowering Prepare a multi-line summary