Skip to content

Conversation

AmrDeveloper
Copy link
Member

Fix the Lowering Prepare a multi-line summary

@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Jul 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-clang

Author: Amr Hesham (AmrDeveloper)

Changes

Fix the Lowering Prepare a multi-line summary


Full diff: https://github.com/llvm/llvm-project/pull/148826.diff

1 Files Affected:

  • (modified) clang/include/clang/CIR/Dialect/Passes.td (+2-2)
diff --git a/clang/include/clang/CIR/Dialect/Passes.td b/clang/include/clang/CIR/Dialect/Passes.td
index 65eb857035224..7d5ec2ffed39d 100644
--- a/clang/include/clang/CIR/Dialect/Passes.td
+++ b/clang/include/clang/CIR/Dialect/Passes.td
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> {
 }
 
 def LoweringPrepare : Pass<"cir-lowering-prepare"> {
-  let summary = "Lower to more fine-grained CIR operations before lowering to
-    other dialects";
+  let summary = "Lower to more fine-grained CIR operations before lowering to "
+    "other dialects";
   let description = [{
     This pass does preparation work for lowering to other dialects. For example,
     it may expand the global variable initialziation in a more ABI-friendly form.

@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-clangir

Author: Amr Hesham (AmrDeveloper)

Changes

Fix the Lowering Prepare a multi-line summary


Full diff: https://github.com/llvm/llvm-project/pull/148826.diff

1 Files Affected:

  • (modified) clang/include/clang/CIR/Dialect/Passes.td (+2-2)
diff --git a/clang/include/clang/CIR/Dialect/Passes.td b/clang/include/clang/CIR/Dialect/Passes.td
index 65eb857035224..7d5ec2ffed39d 100644
--- a/clang/include/clang/CIR/Dialect/Passes.td
+++ b/clang/include/clang/CIR/Dialect/Passes.td
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> {
 }
 
 def LoweringPrepare : Pass<"cir-lowering-prepare"> {
-  let summary = "Lower to more fine-grained CIR operations before lowering to
-    other dialects";
+  let summary = "Lower to more fine-grained CIR operations before lowering to "
+    "other dialects";
   let description = [{
     This pass does preparation work for lowering to other dialects. For example,
     it may expand the global variable initialziation in a more ABI-friendly form.

@AmrDeveloper
Copy link
Member Author

I will quickly merge to make it buildable again

@AmrDeveloper AmrDeveloper merged commit b3240b4 into llvm:main Jul 15, 2025
10 of 12 checks passed
@@ -73,8 +73,8 @@ def CIRFlattenCFG : Pass<"cir-flatten-cfg"> {
}

def LoweringPrepare : Pass<"cir-lowering-prepare"> {
let summary = "Lower to more fine-grained CIR operations before lowering to
other dialects";
let summary = "Lower to more fine-grained CIR operations before lowering to "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this is used, but it may be better to shorten it a bit. Perhaps "Prepare to lower CIR to other dialects"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only one I found is here: mlir/include/mlir/Dialect/Func/TransformOps/FuncTransformOps.td

Yes, I think the summary can be shorter, I will do it with next PR

Copy link
Contributor

@xlauko xlauko Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants