Skip to content

[DebugInfo][NewGVN] Salvage debug values of trivially dead instructions #149304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

[DebugInfo][NewGVN] Salvage debug values of trivially dead instructions #149304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083e9d7
fix 147634
Apochens Jul 17, 2025
680cafd
refine the regression test
Apochens Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/Transforms/Scalar/NewGVN.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3044,6 +3044,7 @@ std::pair<unsigned, unsigned> NewGVN::assignDFSNumbers(BasicBlock *B,
if (isInstructionTriviallyDead(&I, TLI)) {
InstrDFS[&I] = 0;
LLVM_DEBUG(dbgs() << "Skipping trivially dead instruction " << I << "\n");
salvageDebugInfo(I);
markInstructionForDeletion(&I);
continue;
}
Expand Down
33 changes: 33 additions & 0 deletions llvm/test/Transforms/NewGVN/salvage-trivially-dead-inst.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
; RUN: opt -passes=newgvn -S %s | FileCheck %s

; Check that assignDFSNumbers() in NewGVN salvages the debug values of the
; trivially dead instructions that are marked for deletion.

; CHECK: #dbg_value(i8 %tmp, [[META11:![0-9]+]], !DIExpression(DW_OP_constu, 8, DW_OP_eq, DW_OP_stack_value), [[META26:![0-9]+]])
; CHECK: [[META11]] = !DILocalVariable(name: "2"
; CHECK: [[META26]] = !DILocation(line: 2

define void @test13() !dbg !5 {
entry:
%tmp = load i8, ptr null, align 1
%tmp2 = icmp eq i8 %tmp, 8, !dbg !13
#dbg_value(i1 %tmp2, !11, !DIExpression(), !13)
ret void
}

!llvm.dbg.cu = !{!0}
!llvm.debugify = !{!2, !3}
!llvm.module.flags = !{!4}

!0 = distinct !DICompileUnit(language: DW_LANG_C, file: !1, producer: "debugify", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug)
!1 = !DIFile(filename: "/app/example.ll", directory: "/")
!2 = !{i32 3}
!3 = !{i32 2}
!4 = !{i32 2, !"Debug Info Version", i32 3}
!5 = distinct !DISubprogram(name: "test13", linkageName: "test13", scope: null, file: !1, line: 1, type: !6, scopeLine: 1, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !8)
!6 = !DISubroutineType(types: !7)
!7 = !{}
!8 = !{!11}
!10 = !DIBasicType(name: "ty8", size: 8, encoding: DW_ATE_unsigned)
!11 = !DILocalVariable(name: "2", scope: !5, file: !1, line: 2, type: !10)
!13 = !DILocation(line: 2, column: 1, scope: !5)
Loading