Skip to content

Conversation

philnik777
Copy link
Contributor

__all_default_constructible is never used, so we can remove it.

@philnik777 philnik777 marked this pull request as ready for review July 24, 2025 17:17
@philnik777 philnik777 requested a review from a team as a code owner July 24, 2025 17:17
@philnik777 philnik777 merged commit 0f2c31d into llvm:main Jul 24, 2025
77 checks passed
@philnik777 philnik777 deleted the remove_all_default_constructible branch July 24, 2025 17:17
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 24, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

__all_default_constructible is never used, so we can remove it.


Full diff: https://github.com/llvm/llvm-project/pull/150406.diff

1 Files Affected:

  • (modified) libcxx/include/tuple (-6)
diff --git a/libcxx/include/tuple b/libcxx/include/tuple
index 662d926ed35a2..1623702f7ebf6 100644
--- a/libcxx/include/tuple
+++ b/libcxx/include/tuple
@@ -443,12 +443,6 @@ public:
 template <class... _Tp>
 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 void __swallow(_Tp&&...) _NOEXCEPT {}
 
-template <class _Tp>
-struct __all_default_constructible;
-
-template <class... _Tp>
-struct __all_default_constructible<__tuple_types<_Tp...>> : __all<is_default_constructible<_Tp>::value...> {};
-
 // __tuple_impl
 
 template <class _Indx, class... _Tp>

mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
`__all_default_constructible` is never used, so we can remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants