Skip to content

[OFFLOAD] Fix typo in assert #152316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[OFFLOAD] Fix typo in assert #152316

merged 1 commit into from
Aug 6, 2025

Conversation

adurang
Copy link
Contributor

@adurang adurang commented Aug 6, 2025

No description provided.

@llvmbot llvmbot added the offload label Aug 6, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 6, 2025

@llvm/pr-subscribers-offload

Author: Alex Duran (adurang)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/152316.diff

1 Files Affected:

  • (modified) offload/plugins-nextgen/common/src/PluginInterface.cpp (+1-1)
diff --git a/offload/plugins-nextgen/common/src/PluginInterface.cpp b/offload/plugins-nextgen/common/src/PluginInterface.cpp
index 0a7f9fa5970ee..ed79af909674e 100644
--- a/offload/plugins-nextgen/common/src/PluginInterface.cpp
+++ b/offload/plugins-nextgen/common/src/PluginInterface.cpp
@@ -2251,7 +2251,7 @@ GenericPluginTy::create_interop(int32_t ID, int32_t InteropContext,
 int32_t GenericPluginTy::release_interop(int32_t ID,
                                          omp_interop_val_t *Interop) {
   assert(Interop && "Interop is null");
-  assert(Interop->DeviceId == ID && "Interop does not match device id");
+  assert(Interop->device_id == ID && "Interop does not match device id");
   auto &Device = getDevice(ID);
   auto Err = Device.releaseInterop(Interop);
   if (Err) {

@adurang
Copy link
Contributor Author

adurang commented Aug 6, 2025

@mjklemm can you take a look?

@mjklemm mjklemm requested review from kevinsala and mjklemm August 6, 2025 15:00
Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjklemm mjklemm merged commit f092b82 into llvm:main Aug 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants