Skip to content

[CAS] Disable CAS unittests that requires threads #153434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Collaborator

Disable parallel CAS tests when LLVM is configured to not having
threads.

Created using spr 1.3.6
Copy link
Contributor

@evodius96 evodius96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@cachemeifyoucan cachemeifyoucan enabled auto-merge (squash) August 13, 2025 16:52
Created using spr 1.3.6
@cachemeifyoucan
Copy link
Collaborator Author

The PR testing failure is due to #153102. Will merge through the failure to unblock other bots.

@cachemeifyoucan cachemeifyoucan merged commit 7350112 into main Aug 13, 2025
7 of 9 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/cas-disable-cas-unittests-that-requires-threads branch August 13, 2025 18:11
@Kewen12
Copy link
Contributor

Kewen12 commented Aug 13, 2025

It seems the test failure (Clang::avx512bw-builtins.c) persists: https://lab.llvm.org/buildbot/#/builders/10/builds/11363

@cachemeifyoucan
Copy link
Collaborator Author

@Kewen12 that has nothing to do with this PR. see PR linked above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants