Skip to content

[Github] Remove call to llvm-project-tests.yml from mlir-spirv-tests.yml #153871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2025
Merged

[Github] Remove call to llvm-project-tests.yml from mlir-spirv-tests.yml #153871

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b619b2
[𝘀𝗽𝗿] initial version
boomanaiden154 Aug 15, 2025
13066e3
[𝘀𝗽𝗿] changes to main this commit is based on
boomanaiden154 Aug 15, 2025
a61dece
fix
boomanaiden154 Aug 15, 2025
41b41b8
fix
boomanaiden154 Aug 15, 2025
e13e4be
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Aug 16, 2025
5e40208
rebase
boomanaiden154 Aug 16, 2025
573a389
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Aug 16, 2025
a343d45
rebase
boomanaiden154 Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions .github/workflows/mlir-spirv-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,28 @@ jobs:
check_spirv:
if: github.repository_owner == 'llvm'
name: Test MLIR SPIR-V
uses: ./.github/workflows/llvm-project-tests.yml
with:
build_target: check-mlir
projects: mlir
extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="host" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
os_list: '["ubuntu-24.04"]'
runs-on: ubuntu-24.04
container:
image: ghcr.io/llvm/ci-ubuntu-24.04:latest
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Setup ccache
uses: hendrikmuhs/ccache-action@a1209f81afb8c005c13b4296c32e363431bffea5 # v1.2.17
with:
max-size: 2G
key: spirv-mlir-ubuntu-24.04
variant: sccache
- name: Build and Test
run: |
mkdir build
cmake -GNinja \
-S llvm \
-B build \
-DCMAKE_BUILD_TYPE=Release \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to build with clang and lld?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already are. This is run in the CI container where we have a peak optimized clang toolchain. CC and CXX are set so that CMake will pick it up by default, and the toolchain is configured to use lld by default.

Although the last run might not have picked up d0b19cf, which is necessary for CMake to use clang by default.

-DLLVM_ENABLE_ASSERTIONS=ON \
-DCMAKE_C_COMPILER_LAUNCHER=sccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
-DLLVM_TARGETS_TO_BUILD="host" \
-DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON \
-DLLVM_ENABLE_PROJECTS=mlir
ninja -C build check-mlir
Loading