Skip to content

[BOLT] Fix unrecognized option values for print-sorted-by-order #155613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

[BOLT] Fix unrecognized option values for print-sorted-by-order #155613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bolt/lib/Passes/BinaryPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ static cl::opt<DynoStatsSortOrder> DynoStatsSortOrderOpt(
"print-sorted-by-order",
cl::desc("use ascending or descending order when printing functions "
"ordered by dyno stats"),
cl::init(DynoStatsSortOrder::Descending), cl::cat(BoltOptCategory));
cl::init(DynoStatsSortOrder::Descending),
cl::values(clEnumValN(DynoStatsSortOrder::Ascending, "ascending",
"Ascending order"),
clEnumValN(DynoStatsSortOrder::Descending, "descending",
"Descending order")),
cl::cat(BoltOptCategory));

cl::list<std::string>
HotTextMoveSections("hot-text-move-sections",
Expand Down
31 changes: 31 additions & 0 deletions bolt/test/AArch64/print-sorted-by-order.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Check that --print-sorted-by-order=<ascending/descending> option works properly in llvm-bolt
#
# RUN: llvm-mc -filetype=obj -triple aarch64-unknown-unknown %s -o %t.o
# RUN: %clang %cflags -fPIC -pie %t.o -o %t.exe -nostdlib -Wl,-q
# RUN: link_fdata %s %t.o %t.fdata
# RUN: llvm-bolt %t.exe -o %t.bolt --print-sorted-by=all --print-sorted-by-order=ascending \
# RUN: --data %t.fdata | FileCheck %s -check-prefix=CHECK-ASCEND
# RUN: llvm-bolt %t.exe -o %t.bolt --print-sorted-by=all --print-sorted-by-order=descending \
# RUN: --data %t.fdata | FileCheck %s -check-prefix=CHECK-DESCEND

# CHECK-ASCEND: BOLT-INFO: top functions sorted by dyno stats are:
# CHECK-ASCEND-NEXT: bar
# CHECK-ASCEND-NEXT: foo
# CHECK-DESCEND: BOLT-INFO: top functions sorted by dyno stats are:
# CHECK-DESCEND-NEXT: foo
# CHECK-DESCEND-NEXT: bar

.text
.align 4
.global bar
.type bar, %function
bar:
mov w0, wzr
ret

.global foo
.type foo, %function
foo:
# FDATA: 1 foo 0 1 bar 0 0 1
bl bar
ret
Loading