Skip to content

[libcxx][test] Avoid warnings about unused variables and typedefs if _LIBCPP_VERSION is not defined #155679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

[libcxx][test] Avoid warnings about unused variables and typedefs if _LIBCPP_VERSION is not defined #155679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
279aec0
[libcxx][test] Avoid warnings about unused variables and typedefs if …
AlexGuteniev Aug 27, 2025
d395ae4
[[maybe_unused]]
AlexGuteniev Aug 28, 2025
87b01ab
Merge branch 'main' into flat-tests-unused-things-non-libcxx
AlexGuteniev Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ontainers/container.adaptors/flat.map/flat.map.cons/move_assign_noexcept.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ struct MoveThrowsComp {

void test() {
{
using C = std::flat_map<int, int>;
using C [[maybe_unused]] = std::flat_map<int, int>;
LIBCPP_STATIC_ASSERT(std::is_nothrow_move_assignable_v<C>);
}
{
Expand All @@ -73,7 +73,7 @@ void test() {
static_assert(!std::is_nothrow_move_assignable_v<C>);
}
{
using C =
using C [[maybe_unused]] =
std::flat_map<MoveOnly,
int,
std::less<MoveOnly>,
Expand All @@ -82,7 +82,7 @@ void test() {
LIBCPP_STATIC_ASSERT(std::is_nothrow_move_assignable_v<C>);
}
{
using C =
using C [[maybe_unused]] =
std::flat_map<int,
MoveOnly,
std::less<int>,
Expand All @@ -92,7 +92,7 @@ void test() {
}
{
// Test with a comparator that throws on move-assignment.
using C = std::flat_map<int, int, MoveThrowsComp>;
using C [[maybe_unused]] = std::flat_map<int, int, MoveThrowsComp>;
LIBCPP_STATIC_ASSERT(!std::is_nothrow_move_assignable_v<C>);
}
{
Expand Down
3 changes: 2 additions & 1 deletion .../std/containers/container.adaptors/flat.map/flat.map.erasure/erase_if_exceptions.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ struct ErasurePredicate {
};

int main(int, char**) {
const std::pair<int, int> expected[] = {{1, 1}, {2, 2}, {3, 3}, {4, 4}, {5, 5}, {6, 6}, {7, 7}, {8, 8}};
[[maybe_unused]] const std::pair<int, int> expected[] = {
{1, 1}, {2, 2}, {3, 3}, {4, 4}, {5, 5}, {6, 6}, {7, 7}, {8, 8}};
{
using M = std::flat_map<ThrowingAssignment, int, ThrowingComparator>;
for (int first_throw = 1; first_throw < 99; ++first_throw) {
Expand Down
8 changes: 4 additions & 4 deletions ...container.adaptors/flat.multimap/flat.multimap.cons/move_assign_noexcept.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ struct MoveThrowsComp {

void test() {
{
using C = std::flat_multimap<int, int>;
using C [[maybe_unused]] = std::flat_multimap<int, int>;
LIBCPP_STATIC_ASSERT(std::is_nothrow_move_assignable_v<C>);
}
{
Expand All @@ -73,7 +73,7 @@ void test() {
static_assert(!std::is_nothrow_move_assignable_v<C>);
}
{
using C =
using C [[maybe_unused]] =
std::flat_multimap<MoveOnly,
int,
std::less<MoveOnly>,
Expand All @@ -82,7 +82,7 @@ void test() {
LIBCPP_STATIC_ASSERT(std::is_nothrow_move_assignable_v<C>);
}
{
using C =
using C [[maybe_unused]] =
std::flat_multimap<int,
MoveOnly,
std::less<int>,
Expand All @@ -92,7 +92,7 @@ void test() {
}
{
// Test with a comparator that throws on move-assignment.
using C = std::flat_multimap<int, int, MoveThrowsComp>;
using C [[maybe_unused]] = std::flat_multimap<int, int, MoveThrowsComp>;
LIBCPP_STATIC_ASSERT(!std::is_nothrow_move_assignable_v<C>);
}
{
Expand Down
3 changes: 2 additions & 1 deletion ...iners/container.adaptors/flat.multimap/flat.multimap.erasure/erase_if_exceptions.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ struct ErasurePredicate {
};

int main(int, char**) {
const std::pair<int, int> expected[] = {{1, 1}, {2, 2}, {3, 3}, {3, 3}, {5, 5}, {6, 6}, {7, 7}, {8, 8}};
[[maybe_unused]] const std::pair<int, int> expected[] = {
{1, 1}, {2, 2}, {3, 3}, {3, 3}, {5, 5}, {6, 6}, {7, 7}, {8, 8}};
{
using M = std::flat_multimap<ThrowingAssignment, int, ThrowingComparator>;
for (int first_throw = 1; first_throw < 99; ++first_throw) {
Expand Down
2 changes: 1 addition & 1 deletion .../std/containers/container.adaptors/flat.set/flat.set.erasure/erase_if_exceptions.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ struct ErasurePredicate {
};

void test() {
const int expected[] = {1, 2, 3, 4, 5, 6, 7, 8};
[[maybe_unused]] const int expected[] = {1, 2, 3, 4, 5, 6, 7, 8};
{
using M = std::flat_set<ThrowingAssignment, ThrowingComparator>;
for (int first_throw = 1; first_throw < 99; ++first_throw) {
Expand Down
Loading