Skip to content

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Sep 1, 2025

As was already done for HAVE_PTHREAD_(GETNAME/GET_NAME)_NP

As was already done for HAVE_PTHREAD_(GETNAME/GET_NAME)_NP
@llvmbot
Copy link
Member

llvmbot commented Sep 1, 2025

@llvm/pr-subscribers-llvm-support

Author: Brad Smith (brad0)

Changes

As was already done for HAVE_PTHREAD_(GETNAME/GET_NAME)_NP


Full diff: https://github.com/llvm/llvm-project/pull/156294.diff

1 Files Affected:

  • (modified) llvm/lib/Support/Unix/Threading.inc (+2-2)
diff --git a/llvm/lib/Support/Unix/Threading.inc b/llvm/lib/Support/Unix/Threading.inc
index 7854d6d229152..f016ed6937524 100644
--- a/llvm/lib/Support/Unix/Threading.inc
+++ b/llvm/lib/Support/Unix/Threading.inc
@@ -194,9 +194,9 @@ void llvm::set_thread_name(const Twine &Name) {
   if (get_max_thread_name_length() > 0)
     NameStr = NameStr.take_back(get_max_thread_name_length() - 1);
   (void)NameStr;
-#if defined(HAVE_PTHREAD_SET_NAME_NP)
+#if defined(HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_SET_NAME_NP
   ::pthread_set_name_np(::pthread_self(), NameStr.data());
-#elif defined(HAVE_PTHREAD_SETNAME_NP)
+#elif defined(HAVE_PTHREAD_SETNAME_NP) && HAVE_PTHREAD_SETNAME_NP
 #if defined(__NetBSD__)
   ::pthread_setname_np(::pthread_self(), "%s",
                        const_cast<char *>(NameStr.data()));

@brad0 brad0 requested a review from devnexen September 1, 2025 08:20
@brad0 brad0 merged commit 10e5ec8 into llvm:main Sep 1, 2025
11 checks passed
@brad0 brad0 deleted the llvm_unix_threading_setname branch September 1, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants