Skip to content

Conversation

linuxlonelyeagle
Copy link
Member

Previous constant analysis was implemented using the DataFlowAnalysis class.Now it is implemented using SparseForwardDataFlowAnalysis.

@linuxlonelyeagle
Copy link
Member Author

Does anyone else have any suggestions? This analysis seems straightforward, but I'm not sure if we need to add tests.Should we separate constant analysis and run it independently from dead code analysis?

@joker-eph
Copy link
Collaborator

Is this meant to be NFC?

@linuxlonelyeagle
Copy link
Member Author

Is this meant to be NFC?

#149296 (comment) I'm not entirely sure if this PR is NFC.It comes from here.

@linuxlonelyeagle
Copy link
Member Author

Is this meant to be NFC?

I'm not sure if @ftynse has time to review this PR, but if possible, maybe we can address it.

@ftynse
Copy link
Member

ftynse commented Sep 4, 2025

This is a test pass. You need to check what it is supposed to be testing (hopefully in the commit message of the commit that introduce it there is an explanation) as we may need to keep it as is.

What I wanted to see change were the actual DeadCodeAnalysis https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Analysis/DataFlow/DeadCodeAnalysis.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants