Skip to content

Conversation

vzakhari
Copy link
Contributor

@vzakhari vzakhari commented Sep 2, 2025

Here is an example of TBAA attributes generated by Flang:

#tbaa_root = #llvm.tbaa_root<id = "Flang function root _QPtest6">
#tbaa_type_desc = #llvm.tbaa_type_desc<id = "any access", members = {<#tbaa_root, 0>}>

We have to process the text after = to replace the attribute
references with proper check variables.

Here is an example of TBAA attributes generated by Flang:
```
```

We have to process the test after `=` to replace the attribute
references with proper check variables.
@vzakhari vzakhari changed the title [utils] Process attribute references in lines defining attrs.' [utils] Process attribute references in lines defining attrs. Sep 4, 2025
@vzakhari vzakhari requested review from abidh and tblah September 5, 2025 03:48
@vzakhari
Copy link
Contributor Author

vzakhari commented Sep 5, 2025

@abidh @tblah I think you might have hit the issue that the checks generator script does not fully automate the attributes matching (e.g. for TBAA and debug attributes that Flang generates). Please take a look, and let me know if this change would be useful to you.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this would be useful for me thank you. If I remember right I had to do these manually. Are there no lit tests for generate-test-checks.py?

@vzakhari
Copy link
Contributor Author

vzakhari commented Sep 5, 2025

Yes this would be useful for me thank you. If I remember right I had to do these manually. Are there no lit tests for generate-test-checks.py?

I could not find existing tests for this script.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@vzakhari vzakhari merged commit 3ea39a5 into llvm:main Sep 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants