[flang][rt] Remove findloc.cpp from supported_sources fro CUDA build #156542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modiking
added a commit
that referenced
this pull request
Oct 3, 2025
…ful compilation (#161760) NVCC does more aggressive inlining than Clang/GCC causing the exported functions in extrema.cpp and findloc.cpp to become extremely large from function specializations leading to compilation timeouts. Marking the 2 functions in this change as noinline for NVCC alleviates this problem as it removes the worst of the cross-matrix argument specializations. Also remove the workaround in #156542 that opted out findloc.cpp from the CUDA flang-rt build Testing: ninja flang-rt builds in ~30 minutes, these 2 files build in ~3 minutes
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 3, 2025
…for successful compilation (#161760) NVCC does more aggressive inlining than Clang/GCC causing the exported functions in extrema.cpp and findloc.cpp to become extremely large from function specializations leading to compilation timeouts. Marking the 2 functions in this change as noinline for NVCC alleviates this problem as it removes the worst of the cross-matrix argument specializations. Also remove the workaround in llvm/llvm-project#156542 that opted out findloc.cpp from the CUDA flang-rt build Testing: ninja flang-rt builds in ~30 minutes, these 2 files build in ~3 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findloc.cpp is causing memory exhaustion with higher compute capabilities. Also it is a very expensive file to build. Remove it from the supported_sources for CUDA build until we can lower its memory footprint.