[RISCV] Remove remaining vmerge_vl mask patterns. NFC #156566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that RISCVVectorPeephole can commute operands to fold vmerge into a pseudo to make it masked in llvm#156499, we can remove the remaining VPatMultiplyAccVL_VV_VX/VPatFPMulAccVL_VV_VF_RM patterns. It also looks like we can remove the vmerge_vl patterns for _TIED psuedos too. Tested on SPEC CPU 2017 and llvm-test-suite to confirm there's no codegen change. Fixes llvm#141885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RISCVVectorPeephole can commute operands to fold vmerge into a pseudo to make it masked in #156499, we can remove the remaining VPatMultiplyAccVL_VV_VX/VPatFPMulAccVL_VV_VF_RM patterns.
It also looks like we can remove the vmerge_vl patterns for _TIED psuedos too. I suspect they're handled by convertAllOnesVMergeToVMv and foldVMV_V_V
Tested on SPEC CPU 2017 and llvm-test-suite to confirm there's no codegen change.
Fixes #141885