Skip to content

[CoroSplit] Fix use-after-free related to coro.suspend #156572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

[CoroSplit] Fix use-after-free related to coro.suspend #156572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6961a22
[CoroSplit] Fix use after free of coro.suspend
NewSigma Sep 3, 2025
2fa1c66
Add test
NewSigma Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/Coroutines/Coroutines.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,9 @@ void coro::Shape::invalidateCoroutine(
// present.
for (AnyCoroSuspendInst *CS : CoroSuspends) {
CS->replaceAllUsesWith(PoisonValue::get(CS->getType()));
CS->eraseFromParent();
if (auto *CoroSave = CS->getCoroSave())
CoroSave->eraseFromParent();
CS->eraseFromParent();
}
CoroSuspends.clear();

Expand Down
14 changes: 14 additions & 0 deletions llvm/test/Transforms/Coroutines/coro-split-invalid.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
; Tests that coro-split correctly invalidate bad coroutines
; RUN: opt < %s -passes='cgscc(coro-split)' -S | FileCheck %s

define void @pr156444() presplitcoroutine {
; CHECK-LABEL: define void @pr156444(
; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
; CHECK-NEXT: [[ENTRY:.*:]]
; CHECK-NEXT: ret void
;
entry:
%0 = call i8 @llvm.coro.suspend(token none, i1 false)
ret void
}
Loading