Skip to content

[clang][bytecode] Reject final ltor casts on string literals #156669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

[clang][bytecode] Reject final ltor casts on string literals #156669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/AST/ByteCode/EvalEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ template <> bool EvalEmitter::emitRet<PT_Ptr>(const SourceInfo &Info) {
if (!Ptr.isZero() && !Ptr.isDereferencable())
return false;

if (Ptr.pointsToStringLiteral() && Ptr.isArrayRoot())
return false;

if (!Ptr.isZero() && !CheckFinalLoad(S, OpPC, Ptr))
return false;

Expand Down
20 changes: 18 additions & 2 deletions clang/test/AST/ByteCode/openmp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: %clang_cc1 -fexperimental-new-constant-interpreter -verify=expected,both -fopenmp %s
// RUN: %clang_cc1 -verify=ref,both -fopenmp %s
// RUN: %clang_cc1 -verify=expected,both -fopenmp -fopenmp-version=60 %s -fexperimental-new-constant-interpreter
// RUN: %clang_cc1 -verify=ref,both -fopenmp -fopenmp-version=60 %s

int test1() {
int i;
Expand All @@ -11,3 +11,19 @@ int test1() {
for (int i = 0; i < 10; ++i);
}

extern int omp_get_thread_num(void);

#define N 64

int test2() {
int x = 0;
int device_result[N] = {0};

#pragma omp target parallel loop num_threads(strict: N) severity(warning) message("msg")
for (int i = 0; i < N; i++) {
x = omp_get_thread_num();
device_result[i] = i + x;
}
}