Skip to content

Conversation

kazutakahirata
Copy link
Contributor

This is a follow-up for #156810.

@llvmbot
Copy link
Member

llvmbot commented Sep 4, 2025

@llvm/pr-subscribers-llvm-adt

Author: Kazu Hirata (kazutakahirata)

Changes

This is a follow-up for #156810.


Full diff: https://github.com/llvm/llvm-project/pull/156926.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/DenseMapInfo.h (+4-4)
diff --git a/llvm/include/llvm/ADT/DenseMapInfo.h b/llvm/include/llvm/ADT/DenseMapInfo.h
index 717156c4bd196..b91a908d992f8 100644
--- a/llvm/include/llvm/ADT/DenseMapInfo.h
+++ b/llvm/include/llvm/ADT/DenseMapInfo.h
@@ -180,9 +180,9 @@ template <typename... Ts> struct DenseMapInfo<std::tuple<Ts...>> {
   }
 
   template <unsigned I> static unsigned getHashValueImpl(const Tuple &values) {
-    if constexpr (I == sizeof...(Ts))
+    if constexpr (I == sizeof...(Ts)) {
       return 0;
-    else {
+    } else {
       using EltType = std::tuple_element_t<I, Tuple>;
       return detail::combineHashValue(
           DenseMapInfo<EltType>::getHashValue(std::get<I>(values)),
@@ -196,9 +196,9 @@ template <typename... Ts> struct DenseMapInfo<std::tuple<Ts...>> {
 
   template <unsigned I>
   static bool isEqualImpl(const Tuple &lhs, const Tuple &rhs) {
-    if constexpr (I == sizeof...(Ts))
+    if constexpr (I == sizeof...(Ts)) {
       return true;
-    else {
+    } else {
       using EltType = std::tuple_element_t<I, Tuple>;
       return DenseMapInfo<EltType>::isEqual(std::get<I>(lhs),
                                             std::get<I>(rhs)) &&

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kazutakahirata kazutakahirata merged commit b208bda into llvm:main Sep 4, 2025
11 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250904_DenseMapInfo_brace branch September 4, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants