-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[libc++][test] Move the SFINAE test for return types of quoted
to libcxx/test/libcxx/
#157026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[libc++][test] Move the SFINAE test for return types of quoted
to libcxx/test/libcxx/
#157026
Conversation
@llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) Changes[quoted.manip] only specifies that Although it's worthwhile making them SFINAE-friendly, perhaps the SFINAE-friendliness should be considered as a libc++-specific choice at this moment. Full diff: https://github.com/llvm/llvm-project/pull/157026.diff 1 Files Affected:
diff --git a/libcxx/test/std/input.output/iostream.format/quoted.manip/quoted_traits.compile.pass.cpp b/libcxx/test/libcxx/input.output/iostream.format/quoted.manip/quoted_traits.compile.pass.cpp
similarity index 100%
rename from libcxx/test/std/input.output/iostream.format/quoted.manip/quoted_traits.compile.pass.cpp
rename to libcxx/test/libcxx/input.output/iostream.format/quoted.manip/quoted_traits.compile.pass.cpp
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
…libcxx/test/libcxx/` [quoted.manip] only specifies that `operator<<`/`operator>>` is well-formed for operands with suitable types, and leaves it undefined whether they are SFINAE-friendly. Although it's worthwhile making them SFINAE-friendly, perhaps the SFINAE-friendliness should be considered as a libc++-specific choice at this moment. Also clang-format the file to make CI happy.
540094d
to
2fe1e9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't clang-format anything if you only move files. Also, could we get an LWG issue on this?
I originally only moved the file, but CI complained. I'm not sure whether this is worthy filing an LWG issue. |
You can ignore the formatting CI.
There is implementation divergence, no? That seems like a good reason to ask LWG whether they would like to specify this any further or not. |
Opened LWG4364. |
[quoted.manip] only specifies that
operator<<
/operator>>
is well-formed for operands with suitable types, and leaves it undefined whether they are SFINAE-friendly.Although it's worthwhile making them SFINAE-friendly, perhaps the SFINAE-friendliness should be considered as a libc++-specific choice at this moment.
Also clang-format the file to make CI happy.