Skip to content

Conversation

julianmorillo
Copy link
Contributor

Make the test more tolerant (needed for RISC-V, as this target is not expected to emit optimization remarks)

Copy link

github-actions bot commented Sep 5, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added flang:driver flang Flang issues not falling into any other category labels Sep 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 5, 2025

@llvm/pr-subscribers-flang-driver

Author: None (julianmorillo)

Changes

Make the test more tolerant (needed for RISC-V, as this target is not expected to emit optimization remarks)


Full diff: https://github.com/llvm/llvm-project/pull/157036.diff

1 Files Affected:

  • (modified) flang/test/Driver/optimization-remark.f90 (+1-1)
diff --git a/flang/test/Driver/optimization-remark.f90 b/flang/test/Driver/optimization-remark.f90
index 90e310d36c807..dd211f7c8c4fd 100644
--- a/flang/test/Driver/optimization-remark.f90
+++ b/flang/test/Driver/optimization-remark.f90
@@ -19,7 +19,7 @@
 ! RUN: %flang %s -O2 -Rpass=loop -S %{output} 2>&1 | FileCheck %s --check-prefix=PASS-REGEX-LOOP-ONLY
 
 ! Check valid -Rpass-missed regex
-! RUN: %flang %s -O2 -Rpass-missed=loop -S %{output} 2>&1 | FileCheck %s --check-prefix=MISSED-REGEX-LOOP-ONLY
+! RUN: %flang %s -O2 -Rpass-missed=loop -S %{output} 2>&1 | FileCheck %s --allow-empty --check-prefix=MISSED-REGEX-LOOP-ONLY
 
 ! Check valid -Rpass-analysis regex
 ! RUN: %flang %s -O2 -Rpass-analysis=loop -S %{output} 2>&1 | FileCheck %s --check-prefix=ANALYSIS-REGEX-LOOP-ONLY

@julianmorillo julianmorillo changed the title Make test in optimization-remark.f90 more tolerant Mark test in optimization-remark.f90 as UNSUPPORTED on RISC-V Sep 5, 2025
Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Would you like me to merge this?

@julianmorillo
Copy link
Contributor Author

Thank you for the update. Would you like me to merge this?

That would be great, thank you.

@tblah tblah enabled auto-merge (squash) September 8, 2025 11:24
auto-merge was automatically disabled September 8, 2025 13:31

Head branch was pushed to by a user without write access

@tblah tblah enabled auto-merge (squash) September 8, 2025 16:09
@tblah tblah merged commit f1fa037 into llvm:main Sep 8, 2025
9 checks passed
Copy link

github-actions bot commented Sep 8, 2025

@julianmorillo Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@julianmorillo julianmorillo deleted the riscv_optimization_remark branch September 9, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:driver flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants