[Dexter] Work around flaky LLDB DAP stackTrace response #157090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buildbot cross-project-tests-sie-ubuntu sees sporadic test failures due to missing "stackTrace" "source" "path". The "path" field is optional for "source" according to DAP, so it's well formed. It works _most_ of the time, and doesn't consistently fail for any one test which is all strangely inconsistent. I can't replicate the failure locally after running the feature_tests in a loop for 3 hours, and haven't been able to work out why the "source" is sometimes missing by just looking at LLDB code. So, instead, here is a plaster that I am hoping will improve bot consistency. Attempt to get the stack frames with source paths 3 times before giving up. It would be ideal if we didn't need to do any of this. I think `_post_step_hook` could be removed if the behaviour in gh#156650 was fixed/changed.
|
Some kind of workaround is needed for this - do we have confidence that the error is intermittent based on a random chance of getting a bad response from LLDB, though? I think we have to try something, but it would be good if we could get more information in the event that we run out of attempts, so that we aren't back to square 1 if this error ends up appearing again. |
|
How about this instead? #157130 hopefully the DAP logs give us more clues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildbot cross-project-tests-sie-ubuntu sees sporadic test failures due to missing "stackTrace" "source" "path". The "path" field is optional for "source" according to DAP, so it's well formed. It works most of the time, and doesn't consistently fail for any one test which is all strangely inconsistent.
I can't replicate the failures locally after running the feature_tests in a loop for 3 hours, and haven't been able to work out why the "source" is sometimes missing by just looking at LLDB code.
So, instead, here is a plaster that I am hoping will improve bot consistency:
It would be ideal if we didn't need to do any of this. I think
_post_step_hookcould be removed if the behaviour in #156650 was fixed/changed.