Skip to content

Conversation

kparzysz
Copy link
Contributor

@kparzysz kparzysz commented Sep 5, 2025

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Sep 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 5, 2025

@llvm/pr-subscribers-flang-semantics

Author: Krzysztof Parzyszek (kparzysz)

Changes

Example: https://lab.llvm.org/buildbot/#/builders/140/builds/30179


Full diff: https://github.com/llvm/llvm-project/pull/157115.diff

1 Files Affected:

  • (modified) flang/lib/Semantics/check-omp-atomic.cpp (+2-1)
diff --git a/flang/lib/Semantics/check-omp-atomic.cpp b/flang/lib/Semantics/check-omp-atomic.cpp
index ab8aa5f342e48..351af5c099aee 100644
--- a/flang/lib/Semantics/check-omp-atomic.cpp
+++ b/flang/lib/Semantics/check-omp-atomic.cpp
@@ -157,7 +157,8 @@ struct ReassocRewriter : public evaluate::rewrite::Identity {
     // inside of the visitor function in common::visit.
     // Since this works with clang, MSVC and at least GCC 8.5, I'm assuming
     // that this is some kind of a GCC issue.
-    using MatchTypes = std::tuple<evaluate::Add<T>, evaluate::Multiply<T>>;
+    using MatchTypes = std::tuple<evaluate::Add<T>, evaluate::Multiply<T>,
+        evaluate::LogicalOperation<T::kind>>;
 #else
     using MatchTypes = typename decltype(outer1)::MatchTypes;
 #endif

@kparzysz kparzysz merged commit 5fc7e43 into llvm:main Sep 5, 2025
9 checks passed
@kparzysz kparzysz deleted the users/kparzysz/fix-reassoc branch September 5, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:semantics flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants