-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[RISCV] Add th.ext(u) to isSignExtendingOpW in RISCVOptWInstrs. #157147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These instructions extract and range of bits, move them to the LSB then sign or zero extend the result to fill the upper bits. If the extracted bits is small enough then the result will have 33 sign bits.
@llvm/pr-subscribers-backend-risc-v Author: Craig Topper (topperc) ChangesThese instructions extract and range of bits, move them to the LSB Full diff: https://github.com/llvm/llvm-project/pull/157147.diff 2 Files Affected:
diff --git a/llvm/lib/Target/RISCV/RISCVOptWInstrs.cpp b/llvm/lib/Target/RISCV/RISCVOptWInstrs.cpp
index 3b19c3456ad67..2168710e8bfa8 100644
--- a/llvm/lib/Target/RISCV/RISCVOptWInstrs.cpp
+++ b/llvm/lib/Target/RISCV/RISCVOptWInstrs.cpp
@@ -409,6 +409,16 @@ static bool isSignExtendingOpW(const MachineInstr &MI, unsigned OpNo) {
assert(Log2SEW >= 3 && Log2SEW <= 6 && "Unexpected Log2SEW");
return Log2SEW <= 5;
}
+ case RISCV::TH_EXT: {
+ unsigned Msb = MI.getOperand(2).getImm();
+ unsigned Lsb = MI.getOperand(3).getImm();
+ return Msb >= Lsb && (Msb - Lsb + 1) <= 32;
+ }
+ case RISCV::TH_EXTU: {
+ unsigned Msb = MI.getOperand(2).getImm();
+ unsigned Lsb = MI.getOperand(3).getImm();
+ return Msb >= Lsb && (Msb - Lsb + 1) < 32;
+ }
}
return false;
diff --git a/llvm/test/CodeGen/RISCV/rv64xtheadbb.ll b/llvm/test/CodeGen/RISCV/rv64xtheadbb.ll
index 24853ebafefcc..4c7bd8828812f 100644
--- a/llvm/test/CodeGen/RISCV/rv64xtheadbb.ll
+++ b/llvm/test/CodeGen/RISCV/rv64xtheadbb.ll
@@ -1122,3 +1122,101 @@ define i64 @bswap_i64(i64 %a) {
%1 = call i64 @llvm.bswap.i64(i64 %a)
ret i64 %1
}
+
+define void @sextw_removal_ext(i32 signext %arg, i32 signext %arg1) nounwind {
+; RV64I-LABEL: sextw_removal_ext:
+; RV64I: # %bb.0: # %bb
+; RV64I-NEXT: addi sp, sp, -16
+; RV64I-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
+; RV64I-NEXT: sraw a0, a0, a1
+; RV64I-NEXT: .LBB36_1: # %bb2
+; RV64I-NEXT: # =>This Inner Loop Header: Depth=1
+; RV64I-NEXT: call foo
+; RV64I-NEXT: slli a0, a0, 16
+; RV64I-NEXT: srai a0, a0, 32
+; RV64I-NEXT: bnez a0, .LBB36_1
+; RV64I-NEXT: # %bb.2: # %bb7
+; RV64I-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
+; RV64I-NEXT: addi sp, sp, 16
+; RV64I-NEXT: ret
+;
+; RV64XTHEADBB-LABEL: sextw_removal_ext:
+; RV64XTHEADBB: # %bb.0: # %bb
+; RV64XTHEADBB-NEXT: addi sp, sp, -16
+; RV64XTHEADBB-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
+; RV64XTHEADBB-NEXT: sraw a0, a0, a1
+; RV64XTHEADBB-NEXT: .LBB36_1: # %bb2
+; RV64XTHEADBB-NEXT: # =>This Inner Loop Header: Depth=1
+; RV64XTHEADBB-NEXT: call foo
+; RV64XTHEADBB-NEXT: th.ext a0, a0, 47, 16
+; RV64XTHEADBB-NEXT: bnez a0, .LBB36_1
+; RV64XTHEADBB-NEXT: # %bb.2: # %bb7
+; RV64XTHEADBB-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
+; RV64XTHEADBB-NEXT: addi sp, sp, 16
+; RV64XTHEADBB-NEXT: ret
+bb:
+ %i = ashr i32 %arg, %arg1
+ br label %bb2
+
+bb2: ; preds = %bb2, %bb
+ %i3 = phi i32 [ %i, %bb ], [ %i7, %bb2 ]
+ %i4 = tail call i64 @foo(i32 signext %i3)
+ %i5 = shl i64 %i4, 16
+ %i6 = ashr i64 %i5, 32
+ %i7 = trunc i64 %i6 to i32
+ %i8 = icmp eq i32 %i7, 0
+ br i1 %i8, label %bb7, label %bb2
+
+bb7: ; preds = %bb2
+ ret void
+}
+
+declare i64 @foo(i32 signext)
+
+define void @sextw_removal_extu(i32 signext %arg, i32 signext %arg1) nounwind {
+; RV64I-LABEL: sextw_removal_extu:
+; RV64I: # %bb.0: # %bb
+; RV64I-NEXT: addi sp, sp, -16
+; RV64I-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
+; RV64I-NEXT: sraw a0, a0, a1
+; RV64I-NEXT: .LBB37_1: # %bb2
+; RV64I-NEXT: # =>This Inner Loop Header: Depth=1
+; RV64I-NEXT: call foo
+; RV64I-NEXT: slli a0, a0, 16
+; RV64I-NEXT: srli a0, a0, 33
+; RV64I-NEXT: bnez a0, .LBB37_1
+; RV64I-NEXT: # %bb.2: # %bb7
+; RV64I-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
+; RV64I-NEXT: addi sp, sp, 16
+; RV64I-NEXT: ret
+;
+; RV64XTHEADBB-LABEL: sextw_removal_extu:
+; RV64XTHEADBB: # %bb.0: # %bb
+; RV64XTHEADBB-NEXT: addi sp, sp, -16
+; RV64XTHEADBB-NEXT: sd ra, 8(sp) # 8-byte Folded Spill
+; RV64XTHEADBB-NEXT: sraw a0, a0, a1
+; RV64XTHEADBB-NEXT: .LBB37_1: # %bb2
+; RV64XTHEADBB-NEXT: # =>This Inner Loop Header: Depth=1
+; RV64XTHEADBB-NEXT: call foo
+; RV64XTHEADBB-NEXT: th.extu a0, a0, 47, 17
+; RV64XTHEADBB-NEXT: bnez a0, .LBB37_1
+; RV64XTHEADBB-NEXT: # %bb.2: # %bb7
+; RV64XTHEADBB-NEXT: ld ra, 8(sp) # 8-byte Folded Reload
+; RV64XTHEADBB-NEXT: addi sp, sp, 16
+; RV64XTHEADBB-NEXT: ret
+bb:
+ %i = ashr i32 %arg, %arg1
+ br label %bb2
+
+bb2: ; preds = %bb2, %bb
+ %i3 = phi i32 [ %i, %bb ], [ %i7, %bb2 ]
+ %i4 = tail call i64 @foo(i32 signext %i3)
+ %i5 = shl i64 %i4, 16
+ %i6 = lshr i64 %i5, 33
+ %i7 = trunc i64 %i6 to i32
+ %i8 = icmp eq i32 %i7, 0
+ br i1 %i8, label %bb7, label %bb2
+
+bb7: ; preds = %bb2
+ ret void
+}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These instructions extract and range of bits, move them to the LSB
then sign or zero extend the result to fill the upper bits. If
the extracted bits is small enough then the result will have 33
sign bits.