Skip to content

[Option] Mark getLastArg(NoClaim) as noinline. #157163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

[Option] Mark getLastArg(NoClaim) as noinline. #157163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1db9f2
[Option] Mark getLastArg(NoClaim) as noinline.
fhahn Sep 5, 2025
16c1cad
!fixup fix formatting
fhahn Sep 5, 2025
7d4180f
Merge branch 'main' into getargpart-noinline
fhahn Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/include/llvm/Option/ArgList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ class ArgList {
}

/// Return the last argument matching \p Id, or null.
template<typename ...OptSpecifiers>
Arg *getLastArg(OptSpecifiers ...Ids) const {
template <typename... OptSpecifiers>
LLVM_ATTRIBUTE_NOINLINE Arg *getLastArg(OptSpecifiers... Ids) const {
Arg *Res = nullptr;
for (Arg *A : filtered(Ids...)) {
Res = A;
Expand All @@ -265,8 +265,8 @@ class ArgList {

/// Return the last argument matching \p Id, or null. Do not "claim" the
/// option (don't mark it as having been used).
template<typename ...OptSpecifiers>
Arg *getLastArgNoClaim(OptSpecifiers ...Ids) const {
template <typename... OptSpecifiers>
LLVM_ATTRIBUTE_NOINLINE Arg *getLastArgNoClaim(OptSpecifiers... Ids) const {
for (Arg *A : filtered_reverse(Ids...))
return A;
return nullptr;
Expand Down