Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3111,8 +3111,10 @@ void DwarfDebug::emitDebugLocValue(const AsmPrinter &AP, const DIBasicType *BT,
&AP](const DbgValueLocEntry &Entry,
DIExpressionCursor &Cursor) -> bool {
if (Entry.isInt()) {
if (BT && (BT->getEncoding() == dwarf::DW_ATE_signed ||
BT->getEncoding() == dwarf::DW_ATE_signed_char))
if (BT && (BT->getEncoding() == dwarf::DW_ATE_boolean))
DwarfExpr.addBooleanConstant(Entry.getInt());
else if (BT && (BT->getEncoding() == dwarf::DW_ATE_signed ||
BT->getEncoding() == dwarf::DW_ATE_signed_char))
DwarfExpr.addSignedConstant(Entry.getInt());
else
DwarfExpr.addUnsignedConstant(Entry.getInt());
Expand Down
9 changes: 9 additions & 0 deletions llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,15 @@ void DwarfExpression::addStackValue() {
emitOp(dwarf::DW_OP_stack_value);
}

void DwarfExpression::addBooleanConstant(int64_t Value) {
assert(isImplicitLocation() || isUnknownLocation());
LocationKind = Implicit;
if (Value == 0)
emitOp(dwarf::DW_OP_lit0);
else
emitOp(dwarf::DW_OP_lit1);
}

void DwarfExpression::addSignedConstant(int64_t Value) {
assert(isImplicitLocation() || isUnknownLocation());
LocationKind = Implicit;
Expand Down
3 changes: 3 additions & 0 deletions llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ class DwarfExpression {
/// This needs to be called last to commit any pending changes.
void finalize();

/// Emit a boolean constant.
void addBooleanConstant(int64_t Value);

/// Emit a signed constant.
void addSignedConstant(int64_t Value);

Expand Down
38 changes: 38 additions & 0 deletions llvm/test/DebugInfo/debug-bool-const-location.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
; REQUIRES: object-emission
; RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump - | FileCheck %s

; CHECK: {{.*}} DW_TAG_variable
; CHECK-NEXT: {{.*}} DW_AT_location
; CHECK-NEXT: {{.*}} DW_OP_lit0
; CHECK-NEXT: {{.*}} DW_OP_lit1
; CHECK-NOT: {{.*}} DW_OP_lit0, DW_OP_not
; CHECK: {{.*}} DW_AT_name ("arg")

define void @foo() !dbg !5
{
entry:
%arg = alloca i1
store i1 false, i1* %arg
call void @"llvm.dbg.value"(metadata i1 false , metadata !9, metadata !10), !dbg !6
store i1 true, i1* %arg
call void @"llvm.dbg.value"(metadata i1 true , metadata !9, metadata !10), !dbg !7
ret void, !dbg !8
}

declare void @"llvm.dbg.value"(metadata %".1", metadata %".2", metadata %".3")

!llvm.dbg.cu = !{ !2 }
!llvm.module.flags = !{ !11, !12 }

!1 = !DIFile(directory: "", filename: "test")
!2 = distinct !DICompileUnit(emissionKind: FullDebug, file: !1, isOptimized: false, language: DW_LANG_C_plus_plus, runtimeVersion: 0)
!3 = !DIBasicType(encoding: DW_ATE_boolean, name: "bool", size: 8)
!4 = !DISubroutineType(types: !{null})
!5 = distinct !DISubprogram(file: !1, isDefinition: true, isLocal: false, isOptimized: false, line: 5, linkageName: "foo", name: "foo", scope: !1, scopeLine: 5, type: !4, unit: !2)
!6 = !DILocation(column: 1, line: 5, scope: !5)
!7 = !DILocation(column: 1, line: 7, scope: !5)
!8 = !DILocation(column: 1, line: 8, scope: !5)
!9 = !DILocalVariable(arg: 0, file: !1, line: 5, name: "arg", scope: !5, type: !3)
!10 = !DIExpression()
!11 = !{ i32 2, !"Dwarf Version", i32 4 }
!12 = !{ i32 2, !"Debug Info Version", i32 3 }