[NFC][libc++] Fix typo in libcxx/include/__memory/pointer_traits.h

[vinay-deshmukh]

• Apply the typo fix as a separate NFC patch from here: https://github.com/llvm/llvm-project/pull/134330/files#r2313015079

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Developer Policy and LLVM Discourse for more information.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Vinay Deshmukh (vinay-deshmukh)

Changes

• Apply the typo fix as a separate NFC patch from here: https://github.com/llvm/llvm-project/pull/134330/files#r2313015079

---

Full diff: https://github.com/llvm/llvm-project/pull/157304.diff

1 Files Affected:

• (modified) libcxx/include/__memory/pointer_traits.h (+1-1)

diff --git a/libcxx/include/__memory/pointer_traits.h b/libcxx/include/__memory/pointer_traits.h
index 8c7f8dff1b76b..62fcd93263b02 100644
--- a/libcxx/include/__memory/pointer_traits.h
+++ b/libcxx/include/__memory/pointer_traits.h
@@ -255,7 +255,7 @@ concept __resettable_smart_pointer_with_args = requires(_Smart __s, _Pointer __p
 // This function ensures safe conversions between fancy pointers at compile-time, where we avoid casts from/to
 // `__void_pointer` by obtaining the underlying raw pointer from the fancy pointer using `std::to_address`,
 // then dereferencing it to retrieve the pointed-to object, and finally constructing the target fancy pointer
-// to that object using the `std::pointer_traits<>::pinter_to` function.
+// to that object using the `std::pointer_traits<>::pointer_to` function.
 template <class _PtrTo, class _PtrFrom>
 _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI _PtrTo __static_fancy_pointer_cast(const _PtrFrom& __p) {
   using __ptr_traits   = pointer_traits<_PtrTo>;

[frederick-vs-ja]

LGTM now.

@philnik777 If #152989 won't be resolved soon, I think we should at least merge this.

[frederick-vs-ja]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off Keep my email addresses private setting in your account. See LLVM Developer Policy and LLVM Discourse for more information.

@vinay-deshmukh Could you make your e-mail address public according to our general convention?

[vinay-deshmukh]

@frederick-vs-ja

I've pushed a new commit with the correct email address. let me know if that works or if I need to rebase/edit all existing commits.

P.S. I don't have "merge" permissions, so will need a reviewer to merge the change for me as well...

[frederick-vs-ja]

@frederick-vs-ja

I've pushed a new commit with the correct email address. let me know if that works or if I need to rebase/edit all existing commits.

P.S. I don't have "merge" permissions, so will need a reviewer to merge the change for me as well...

I think you should set your GitHub account to make the email address public.

[vinay-deshmukh]

Maybe that setting does not affect the commits that are not already pushed?

[philnik777]

@vinay-deshmukh The merge E-Mail is important. It's correct now.