Skip to content

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Sep 7, 2025

Reverts #156675 due to regressions in standalone build and test errors without all plugins enabled (#157345).

@llvmbot llvmbot added the offload label Sep 7, 2025
@mgorny mgorny enabled auto-merge (squash) September 7, 2025 15:09
@llvmbot
Copy link
Member

llvmbot commented Sep 7, 2025

@llvm/pr-subscribers-offload

Author: Michał Górny (mgorny)

Changes

Reverts llvm/llvm-project#156675 due to regressions in standalone build and test errors without all plugins enabled (#157345).


Full diff: https://github.com/llvm/llvm-project/pull/157346.diff

1 Files Affected:

  • (modified) offload/test/CMakeLists.txt (+1-1)
diff --git a/offload/test/CMakeLists.txt b/offload/test/CMakeLists.txt
index c317394ada66f..711621de9075d 100644
--- a/offload/test/CMakeLists.txt
+++ b/offload/test/CMakeLists.txt
@@ -61,7 +61,7 @@ add_offload_testsuite(check-offload
   "Running libomptarget tests"
   ${LIBOMPTARGET_LIT_TESTSUITES}
   EXCLUDE_FROM_CHECK_ALL
-  DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS} check-offload-unit
+  DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS}
   ARGS ${LIBOMPTARGET_LIT_ARG_LIST})
 
 # Add liboffload unit tests - the test binary will run on all available devices

@jhuber6
Copy link
Contributor

jhuber6 commented Sep 7, 2025

Also while we're here, I'd like to delete the current standalone build and replace it with the runtimes build. The one where you do cmake ../runtimes -DLLVM_ENABLE_RUNTIMES=offload. Is that something we could move towards?

@mgorny mgorny merged commit 7a88ddd into main Sep 7, 2025
11 checks passed
@mgorny mgorny deleted the revert-156675-offload_test branch September 7, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants