Skip to content

[Mips] Remove size operand of LwRxPcTcp16 / LwRxPcTcpX16 #157348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
Merged

[Mips] Remove size operand of LwRxPcTcp16 / LwRxPcTcpX16 #157348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Target/Mips/Mips16InstrInfo.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class FRI16_ins<bits<5> op, string asmstr,

class FRI16_TCP_ins<bits<5> _op, string asmstr,
InstrItinClass itin>:
FRI16<_op, (outs CPU16Regs:$rx), (ins pcrel16:$imm8, i32imm:$size),
FRI16<_op, (outs CPU16Regs:$rx), (ins pcrel16:$imm8),
!strconcat(asmstr, "\t$rx, $imm8\t# 16 bit inst"), [], itin>;

class FRI16R_ins_base<bits<5> op, string asmstr, string asmstr2,
Expand Down Expand Up @@ -216,7 +216,7 @@ class FEXT_RI16_B_ins<bits<5> _op, string asmstr,

class FEXT_RI16_TCP_ins<bits<5> _op, string asmstr,
InstrItinClass itin>:
FEXT_RI16<_op, (outs CPU16Regs:$rx), (ins pcrel16:$imm16, i32imm:$size),
FEXT_RI16<_op, (outs CPU16Regs:$rx), (ins pcrel16:$imm16),
!strconcat(asmstr, "\t$rx, $imm16"), [], itin>;

class FEXT_2RI16_ins<bits<5> _op, string asmstr,
Expand Down Expand Up @@ -857,6 +857,7 @@ def LwRxSpImmX16: FEXT_RRI16_mem_ins<0b10010, "lw", mem16sp, II_LW>, MayLoad;
def LwRxPcTcp16: FRI16_TCP_ins<0b10110, "lw", II_LW>, MayLoad;

def LwRxPcTcpX16: FEXT_RI16_TCP_ins<0b10110, "lw", II_LW>, MayLoad;

//
// Format: MOVE r32, rz MIPS16e
// Purpose: Move
Expand Down
1 change: 0 additions & 1 deletion llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,7 +1647,6 @@ void MipsConstantIslands::prescanForConstants() {
MI.removeOperand(1);
MI.removeOperand(1);
MI.addOperand(MachineOperand::CreateCPI(index, 0));
MI.addOperand(MachineOperand::CreateImm(4));
}
break;
}
Expand Down