-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[mlir] Self-nominate for arith dialect maintenance #157355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-mlir Author: Jakub Kuderski (kuhar) ChangesFollowing https://llvm.org/docs/DeveloperPolicy.html#maintainers, I'd like to self-nominate for arith dialect maintenance. As per the policy: I believe I've been already performing most of the maintenance duties over the past few years, including direct code contributions, code reviews, and both starting and participating in relevant RFCs on discourse. You can look those up with:
In addition to the Full diff: https://github.com/llvm/llvm-project/pull/157355.diff 1 Files Affected:
diff --git a/mlir/Maintainers.md b/mlir/Maintainers.md
index 02e93eb658279..5d3b576c2e751 100644
--- a/mlir/Maintainers.md
+++ b/mlir/Maintainers.md
@@ -46,7 +46,7 @@ dialects, build system and language bindings.
* ‘ptr’ Dialect ([fabianmcg](https://github.com/fabianmcg))
#### Basic Compute Dialects
-* ‘arith’ Dialect (core)
+* ‘arith’ Dialect (core + [kuhar](https://github.com/kuhar))
* ‘math’ Dialect (core)
* Rewrite System Dialects (core)
* Transform Dialect ([martin-luecke](https://github.com/martin-luecke), [ftynse](https://github.com/ftynse), [rolfmorel](https://github.com/rolfmorel))
|
LGTM. |
LGTM (I'm guessing we will have the mlir council leads land the PR) |
I'm happy with this, too. I'll let the others in the area team acknowledge. |
LGTM |
LGTM! |
LGTM |
Following https://llvm.org/docs/DeveloperPolicy.html#maintainers, I'd like to self-nominate for arith dialect maintenance.
As per the policy:
I believe I've been already performing most of the maintenance duties over the past few years, including direct code contributions, code reviews, and both starting and participating in relevant RFCs on discourse. You can look those up with:
git log --author=Jakub --oneline -- 'mlir/include/mlir/Dialect/Arith*' 'mlir/lib/Dialect/Arith*'
In addition to the
core
category maintainers, I can bring additional perspective as I care both about conversion to llvm (as a user) and to spirv (as a maintainer).