Skip to content

Conversation

nicovank
Copy link
Contributor

@nicovank nicovank commented Sep 8, 2025

Fix #157343.

@llvmbot
Copy link
Member

llvmbot commented Sep 8, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Nicolas van Kempen (nicovank)

Changes

Fix #157343.


Full diff: https://github.com/llvm/llvm-project/pull/157384.diff

1 Files Affected:

  • (modified) clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst (+1-1)
diff --git a/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst b/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
index 05f1d85f1af5a..eb605c5b0a53b 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
@@ -9,5 +9,5 @@ marked with ``noexcept`` or marked with ``noexcept(expr)`` where ``expr``
 evaluates to ``false`` (but is not a ``false`` literal itself).
 
 Move constructors of all the types used with STL containers, for example,
-need to be declared ``noexcept``. Otherwise STL will choose copy constructors
+should be declared ``noexcept``. Otherwise STL may choose copy constructors
 instead. The same is valid for move assignment operations.

@llvmbot
Copy link
Member

llvmbot commented Sep 8, 2025

@llvm/pr-subscribers-clang-tidy

Author: Nicolas van Kempen (nicovank)

Changes

Fix #157343.


Full diff: https://github.com/llvm/llvm-project/pull/157384.diff

1 Files Affected:

  • (modified) clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst (+1-1)
diff --git a/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst b/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
index 05f1d85f1af5a..eb605c5b0a53b 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/performance/noexcept-move-constructor.rst
@@ -9,5 +9,5 @@ marked with ``noexcept`` or marked with ``noexcept(expr)`` where ``expr``
 evaluates to ``false`` (but is not a ``false`` literal itself).
 
 Move constructors of all the types used with STL containers, for example,
-need to be declared ``noexcept``. Otherwise STL will choose copy constructors
+should be declared ``noexcept``. Otherwise STL may choose copy constructors
 instead. The same is valid for move assignment operations.

@nicovank nicovank requested a review from vbvictor September 8, 2025 04:44
@nicovank
Copy link
Contributor Author

nicovank commented Sep 8, 2025

Feel free to ship immediately if OK.

Turns out, I can enable and test out auto-merge 😮 let's see what happens.

@nicovank nicovank enabled auto-merge (squash) September 8, 2025 04:51
@nicovank nicovank merged commit c5ed3c6 into llvm:main Sep 8, 2025
13 checks passed
@nicovank
Copy link
Contributor Author

nicovank commented Sep 8, 2025

Wow, I thought auto merge would wait for a reviewer approval. Oops. Good thing this is harmless. Please let me know if there was an issue.

@nicovank nicovank deleted the pr157384 branch September 8, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clang-tidy] false positives in check performance-noexcept-move-constructor
3 participants