Skip to content

[MLIR][NVVM] Fix undef in cp.async.bulk.tensor.reduce Op #157423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 23, 2025
Merged

[MLIR][NVVM] Fix undef in cp.async.bulk.tensor.reduce Op #157423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0593fd9
[MLIR][NVVM] Fix undef in cp.async.bulk.tensor.reduce Op
Wolfram70 Sep 8, 2025
6ad4d3c
address comments
Wolfram70 Sep 9, 2025
b715372
fix format
Wolfram70 Sep 9, 2025
02ee37d
remove macro
Wolfram70 Sep 9, 2025
6a1daf0
address comments
Wolfram70 Sep 15, 2025
fb1be2f
add asserts
Wolfram70 Sep 15, 2025
5098808
rename noIntrinsic to notIntrinsic
Wolfram70 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2795,35 +2795,17 @@ def NVVM_CpAsyncBulkTensorReduceOp :
}];

let extraClassDeclaration = [{
static llvm::Intrinsic::ID getIntrinsicID(int tensorDims,
NVVM::TMAReduxKind kind,
bool isIm2Col);
static mlir::NVVM::IDArgPair
getIntrinsicIDAndArgs(Operation &op,
LLVM::ModuleTranslation &mt, llvm::IRBuilderBase& builder);
}];

let hasVerifier = 1;

string llvmBuilder = [{
// Arguments to the intrinsic:
// shared_mem_ptr, tmaDesc, tensorDims
// cache_hint(if applicable) and flag(boolean)
llvm::SmallVector<llvm::Value *> translatedOperands;
translatedOperands.push_back($srcMem);
translatedOperands.push_back($tmaDescriptor);

for (auto v : op.getCoordinates())
translatedOperands.push_back(moduleTranslation.lookupValue(v));

llvm::LLVMContext &ctx = moduleTranslation.getLLVMContext();
auto *i64Undef = llvm::UndefValue::get(llvm::IntegerType::get(ctx, 64));

bool isCacheHint = op.getL2CacheHint() ? true : false;
translatedOperands.push_back(isCacheHint ? $l2CacheHint : i64Undef);
translatedOperands.push_back(builder.getInt1(isCacheHint));

auto intId = NVVM::CpAsyncBulkTensorReduceOp::getIntrinsicID(
op.getCoordinates().size(), $redKind,
(op.getMode() == NVVM::TMAStoreMode::IM2COL));
createIntrinsicCall(builder, intId, translatedOperands);
auto [id, args] = NVVM::CpAsyncBulkTensorReduceOp::getIntrinsicIDAndArgs(
*op, moduleTranslation, builder);
createIntrinsicCall(builder, id, args);
}];
}

Expand Down
183 changes: 139 additions & 44 deletions mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,53 +1634,148 @@ CpAsyncBulkTensorSharedCTAToGlobalOp::getIntrinsicIDAndArgs(
return {id, std::move(args)};
}

#define CP_ASYNC_BULK_TENSOR_REDUCE_MODE(op, dim, mode) \
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_##op##_##mode##_##dim##d
NVVM::IDArgPair CpAsyncBulkTensorReduceOp::getIntrinsicIDAndArgs(
Operation &op, LLVM::ModuleTranslation &mt, llvm::IRBuilderBase &builder) {
auto thisOp = cast<NVVM::CpAsyncBulkTensorReduceOp>(op);
llvm::LLVMContext &ctx = mt.getLLVMContext();

#define CP_ASYNC_BULK_TENSOR_REDUCE(op, dim, is_im2col) \
is_im2col ? CP_ASYNC_BULK_TENSOR_REDUCE_MODE(op, dim, im2col) \
: CP_ASYNC_BULK_TENSOR_REDUCE_MODE(op, dim, tile)
llvm::SmallVector<llvm::Value *> args;

#define GET_CP_ASYNC_BULK_TENSOR_ID(op, dims, is_im2col) \
[&]() -> auto { \
switch (dims) { \
case 1: \
return CP_ASYNC_BULK_TENSOR_REDUCE_MODE(op, 1, tile); \
case 2: \
return CP_ASYNC_BULK_TENSOR_REDUCE_MODE(op, 2, tile); \
case 3: \
return CP_ASYNC_BULK_TENSOR_REDUCE(op, 3, is_im2col); \
case 4: \
return CP_ASYNC_BULK_TENSOR_REDUCE(op, 4, is_im2col); \
case 5: \
return CP_ASYNC_BULK_TENSOR_REDUCE(op, 5, is_im2col); \
default: \
llvm_unreachable("Invalid TensorDim in CpAsyncBulkTensorReduceOp."); \
} \
}()
// Arguments to the intrinsic:
// shared_mem_ptr, tmaDesc, tensorDims
// cache_hint(if applicable) and flag(boolean)
args.push_back(mt.lookupValue(thisOp.getSrcMem()));
args.push_back(mt.lookupValue(thisOp.getTmaDescriptor()));

for (Value v : thisOp.getCoordinates())
args.push_back(mt.lookupValue(v));

mlir::Value cacheHint = thisOp.getL2CacheHint();
const bool hasCacheHint = static_cast<bool>(cacheHint);
llvm::Value *i64ZeroValue =
llvm::ConstantInt::get(llvm::Type::getInt64Ty(ctx), 0);
args.push_back(hasCacheHint ? mt.lookupValue(cacheHint) : i64ZeroValue);
args.push_back(builder.getInt1(hasCacheHint));

const llvm::Intrinsic::ID notIntrinsic = llvm::Intrinsic::not_intrinsic;

constexpr unsigned numRedKinds = 8; // ADD, MIN, MAX, INC, DEC, AND, OR, XOR
constexpr unsigned numLayouts = 2; // TILE, IM2COL
constexpr unsigned maxDim = 5; // 1D to 5D
using row = std::array<llvm::Intrinsic::ID, maxDim + 1>;
using layoutTable = std::array<row, numLayouts>;
using fullTable = std::array<layoutTable, numRedKinds>;
static constexpr fullTable IDTable{
{// RedTy::ADD
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_add_im2col_5d}}}},
// RedTy::MIN
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_min_im2col_5d}}}},
// RedTy::MAX
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_max_im2col_5d}}}},
// RedTy::INC
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_inc_im2col_5d}}}},
// RedTy::DEC
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_dec_im2col_5d}}}},
// RedTy::AND
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_and_im2col_5d}}}},
// RedTy::OR
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_im2col_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_or_im2col_5d}}}},
// RedTy::XOR
{{{{notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_tile_1d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_tile_2d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_tile_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_tile_4d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_tile_5d}},
{{notIntrinsic, notIntrinsic, notIntrinsic,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_im2col_3d,
llvm::Intrinsic::nvvm_cp_async_bulk_tensor_reduce_xor_im2col_4d,
llvm::Intrinsic::
nvvm_cp_async_bulk_tensor_reduce_xor_im2col_5d}}}}}};

static_assert(getMaxEnumValForTMAReduxKind() == std::size(IDTable) - 1,
"TMAReduxKinds must match number of rows in IDTable");

size_t redKind = static_cast<size_t>(thisOp.getRedKind());
size_t mode = static_cast<size_t>(thisOp.getMode());
size_t dim = thisOp.getCoordinates().size();

assert(redKind < IDTable.size() &&
"Invalid redKind for CpAsyncBulkTensorReduceOp");
assert(mode < IDTable[redKind].size() &&
"Invalid mode for CpAsyncBulkTensorReduceOp");
assert(dim < IDTable[redKind][mode].size() &&
"Invalid dim for CpAsyncBulkTensorReduceOp");

llvm::Intrinsic::ID intrinsicID = IDTable[redKind][mode][dim];

assert(intrinsicID != notIntrinsic &&
"Invalid intrinsic for CpAsyncBulkTensorReduceOp.");

llvm::Intrinsic::ID CpAsyncBulkTensorReduceOp::getIntrinsicID(
int tensorDims, NVVM::TMAReduxKind kind, bool isIm2Col) {
using RedTy = NVVM::TMAReduxKind;
switch (kind) {
case RedTy::ADD:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_add, tensorDims, isIm2Col);
case RedTy::MIN:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_min, tensorDims, isIm2Col);
case RedTy::MAX:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_max, tensorDims, isIm2Col);
case RedTy::INC:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_inc, tensorDims, isIm2Col);
case RedTy::DEC:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_dec, tensorDims, isIm2Col);
case RedTy::AND:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_and, tensorDims, isIm2Col);
case RedTy::OR:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_or, tensorDims, isIm2Col);
case RedTy::XOR:
return GET_CP_ASYNC_BULK_TENSOR_ID(reduce_xor, tensorDims, isIm2Col);
}
llvm_unreachable("Invalid Reduction Op for CpAsyncBulkTensorReduceOp");
return {intrinsicID, std::move(args)};
}

#define _none
Expand Down
Loading