Skip to content

Conversation

matthias-springer
Copy link
Member

No description provided.

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Sep 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 8, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Matthias Springer (matthias-springer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/157491.diff

1 Files Affected:

  • (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (-2)
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 0f24235eaf42c..36ee87b533b3b 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1910,8 +1910,6 @@ void ConversionPatternRewriterImpl::replaceOp(
     }
 
     // Remap result to replacement value.
-    if (repl.empty())
-      continue;
     mapping.map(static_cast<Value>(result), std::move(repl));
   }
 

@matthias-springer matthias-springer enabled auto-merge (squash) September 8, 2025 15:38
@matthias-springer matthias-springer merged commit 216bf6e into main Sep 8, 2025
12 checks passed
@matthias-springer matthias-springer deleted the users/matthias-springer/dead_code branch September 8, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants