Skip to content

[Utils] Ensure that empty.txt is always empty #157576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

[Utils] Ensure that empty.txt is always empty #157576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f745ce8
[Utils] Ensure that empty.txt is always empty
hnrklssn Sep 8, 2025
af9b03c
[Utils] Make test agnostic to path separator (NFC)
hnrklssn Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/utils/lit/tests/Inputs/diff-test-update/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
*.txt
; diff-tmp-dir.test clobbers this file
empty.txt
4 changes: 3 additions & 1 deletion llvm/utils/lit/tests/Inputs/diff-test-update/diff-tmp-dir.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# RUN: mkdir %t
# RUN: touch %S/empty.txt
# Tests that if file A is in the %t directory and file B is not,
# the diff test updater copies from file A to B.
# RUN: echo "" > %S/empty.txt
# RUN: cp %S/1.in %t/1.txt

# RUN: diff %t/1.txt %S/empty.txt
Expand Down
10 changes: 5 additions & 5 deletions llvm/utils/lit/tests/diff-test-update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# RUN: not %{lit} --update-tests -v %S/Inputs/diff-test-update | FileCheck %s

# CHECK: # update-diff-test: could not deduce source and target from {{.*}}/Inputs/diff-test-update/1.in and {{.*}}/Inputs/diff-test-update/2.in
# CHECK: # update-diff-test: could not deduce source and target from {{.*}}/diff-test-update/Output/diff-bail2.test.tmp/1.txt and {{.*}}/diff-test-update/Output/diff-bail2.test.tmp/2.txt
# CHECK: # update-diff-test: copied {{.*}}/Output/diff-expected.test.tmp/my-file.txt to {{.*}}/Output/diff-expected.test.tmp/my-file.expected
# CHECK: # update-diff-test: copied {{.*}}/Output/diff-tmp-dir.test.tmp/1.txt to {{.*}}/Inputs/diff-test-update/empty.txt
# CHECK: # update-diff-test: copied {{.*}}/Inputs/diff-test-update/Output/diff-tmp.test.tmp.txt to {{.*}}/Inputs/diff-test-update/diff-t-out.txt
# CHECK: # update-diff-test: could not deduce source and target from {{.*}}1.in and {{.*}}2.in
# CHECK: # update-diff-test: could not deduce source and target from {{.*}}1.txt and {{.*}}2.txt
# CHECK: # update-diff-test: copied {{.*}}my-file.txt to {{.*}}my-file.expected
# CHECK: # update-diff-test: copied {{.*}}1.txt to {{.*}}empty.txt
# CHECK: # update-diff-test: copied {{.*}}diff-tmp.test.tmp.txt to {{.*}}diff-t-out.txt


# CHECK: Failed: 5 (100.00%)