Skip to content

[Offload] Make ASSERT_ERROR output more readable #157653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

[Offload] Make ASSERT_ERROR output more readable #157653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions offload/unittests/OffloadAPI/common/Fixtures.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,16 @@
} while (0)
#endif

// TODO: rework this so the EXPECTED/ACTUAL results are readable
#ifndef ASSERT_ERROR
#define ASSERT_ERROR(EXPECTED, ACTUAL) \
do { \
ol_result_t Res = ACTUAL; \
ASSERT_TRUE(Res && (Res->Code == EXPECTED)); \
if (!Res) \
GTEST_FAIL() << #ACTUAL " succeeded when we expected it to fail"; \
if (Res->Code != EXPECTED) \
GTEST_FAIL() << #ACTUAL " was expected to return " \
<< #EXPECTED " but instead returned " << Res->Code << ": " \
<< Res->Details; \
} while (0)
#endif

Expand Down
Loading