[libc++] Don't mark lgamma_r as noexcept on Fuchsia #157710
Conversation
Building on Fuchsia is broken after llvm#156547. This disables the NOEXCEPT on Fuchsia to unbreak things. Hopefully we can come up with a more forward-compatible fix later.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Nico Weber (nico) ChangesBuilding on Fuchsia is broken after #156547. Full diff: https://github.com/llvm/llvm-project/pull/157710.diff 1 Files Affected:
diff --git a/libcxx/include/__random/binomial_distribution.h b/libcxx/include/__random/binomial_distribution.h
index bada8cfdd74a3..816135216d970 100644
--- a/libcxx/include/__random/binomial_distribution.h
+++ b/libcxx/include/__random/binomial_distribution.h
@@ -104,7 +104,7 @@ class binomial_distribution {
# else
# define _LIBCPP_LGAMMA_R_NOEXCEPT
# endif
-#elif defined(__LLVM_LIBC__)
+#elif defined(__LLVM_LIBC__) && !defined(__Fuchsia__)
# define _LIBCPP_LGAMMA_R_NOEXCEPT _NOEXCEPT
#else
# define _LIBCPP_LGAMMA_R_NOEXCEPT
|
The Fuchsia libc header change is already in progress and should percolate to Fuchsia SDK builds available for public consumption later today. Landing this change now would make libc++ incompatible with the new state of Fuchsia libc, so please do not land this. |
|
Where can I follow that change and the SDK push? |
|
We successfully updated our Fuchsia SDK and things work for us as-is. Closing, thanks everyone. (ref crbug.com/443929394) |
Building on Fuchsia is broken after #156547.
This disables the NOEXCEPT on Fuchsia to unbreak things. Hopefully we can come up with a more forward-compatible fix later.