Skip to content

Conversation

kazutakahirata
Copy link
Contributor

st::type_identity_t is from C++20, not C++23.

st::type_identity_t is from C++20, not C++23.
@llvmbot
Copy link
Member

llvmbot commented Sep 10, 2025

@llvm/pr-subscribers-llvm-adt

Author: Kazu Hirata (kazutakahirata)

Changes

st::type_identity_t is from C++20, not C++23.


Full diff: https://github.com/llvm/llvm-project/pull/157789.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/STLForwardCompat.h (+2-2)
diff --git a/llvm/include/llvm/ADT/STLForwardCompat.h b/llvm/include/llvm/ADT/STLForwardCompat.h
index 81b9a685e11d2..0ef8cb5d02e50 100644
--- a/llvm/include/llvm/ADT/STLForwardCompat.h
+++ b/llvm/include/llvm/ADT/STLForwardCompat.h
@@ -36,7 +36,7 @@ template <typename T>
 using remove_cvref_t // NOLINT(readability-identifier-naming)
     = typename llvm::remove_cvref<T>::type;
 
-// TODO: Remove this in favor of std::type_identity<T> once we switch to C++23.
+// TODO: Remove this in favor of std::type_identity<T> once we switch to C++20.
 template <typename T>
 struct type_identity // NOLINT(readability-identifier-naming)
 {
@@ -44,7 +44,7 @@ struct type_identity // NOLINT(readability-identifier-naming)
 };
 
 // TODO: Remove this in favor of std::type_identity_t<T> once we switch to
-// C++23.
+// C++20.
 template <typename T>
 using type_identity_t // NOLINT(readability-identifier-naming)
     = typename llvm::type_identity<T>::type;

@kazutakahirata kazutakahirata merged commit cac3802 into llvm:main Sep 10, 2025
11 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250909_ADT_STLForwardCompat_type_identity branch September 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants