Skip to content

[flang][OpenMP] Fix crash on DECLARE REDUCTION in unparse-with-symbols #157871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

[flang][OpenMP] Fix crash on DECLARE REDUCTION in unparse-with-symbols #157871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion flang/lib/Semantics/unparse-with-symbols.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class SymbolDumpVisitor {
template <typename T> void Post(const parser::Statement<T> &) {
currStmt_ = std::nullopt;
}
void Post(const parser::Name &name);

bool Pre(const parser::AccClause &clause) {
currStmt_ = clause.source;
return true;
Expand All @@ -57,7 +59,6 @@ class SymbolDumpVisitor {
return true;
}
void Post(const parser::OpenMPThreadprivate &) { currStmt_ = std::nullopt; }
void Post(const parser::Name &name);

bool Pre(const parser::OpenMPDeclareMapperConstruct &x) {
currStmt_ = x.source;
Expand All @@ -67,6 +68,14 @@ class SymbolDumpVisitor {
currStmt_ = std::nullopt;
}

bool Pre(const parser::OpenMPDeclareReductionConstruct &x) {
currStmt_ = x.source;
return true;
}
void Post(const parser::OpenMPDeclareReductionConstruct &) {
currStmt_ = std::nullopt;
}

bool Pre(const parser::OpenMPDeclareTargetConstruct &x) {
currStmt_ = x.source;
return true;
Expand Down Expand Up @@ -120,6 +129,7 @@ void SymbolDumpVisitor::Indent(llvm::raw_ostream &out, int indent) const {
void SymbolDumpVisitor::Post(const parser::Name &name) {
if (const auto *symbol{name.symbol}) {
if (!symbol->has<MiscDetails>()) {
CHECK(currStmt_.has_value());
symbols_.emplace(currStmt_.value().begin(), symbol);
}
}
Expand Down
13 changes: 13 additions & 0 deletions flang/test/Parser/OpenMP/declare-reduction-unparse-with-symbols.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
!RUN: %flang_fc1 -fdebug-unparse-with-symbols -fopenmp %s | FileCheck %s

! This used to crash.

subroutine f00
!$omp declare reduction(fred : integer, real : omp_out = omp_in + omp_out)
end

!CHECK: !DEF: /f00 (Subroutine) Subprogram
!CHECK: subroutine f00
!CHECK: !$omp declare reduction (fred:integer,real:omp_out = omp_in+omp_out)
!CHECK: end subroutine