-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[mlir][xegpu] Add utilities for xegpu::sliceAttr
#157970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (!checkTranspose($_self.getLaneLayoutAsInt(), other.getLaneLayoutAsInt(), perm)) | ||
return false; | ||
// check laneData | ||
if (!checkTranspose($_self.getLaneDataAsInt(), other.getLaneDataAsInt(), perm)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
order attribute needs to be transposed.
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-gpu Author: Charitha Saumya (charithaintc) Changes
Full diff: https://github.com/llvm/llvm-project/pull/157970.diff 2 Files Affected:
diff --git a/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td b/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
index cfe3e800484ce..aa3e3c5cddc05 100644
--- a/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
+++ b/mlir/include/mlir/Dialect/XeGPU/IR/XeGPUAttrs.td
@@ -231,7 +231,55 @@ def DistributeLayoutAttr: AttrInterface<"DistributeLayoutAttr"> {
multiple blocks according to round-robin distribution rules.}],
"FailureOr<SmallVector<SmallVector<Value>>>",
"getOffsets",
- (ins "OpBuilder &": $builder, "Location":$loc, "Value":$linearId, "ArrayRef<int64_t>":$shape)>
+ (ins "OpBuilder &": $builder, "Location":$loc, "Value":$linearId, "ArrayRef<int64_t>":$shape)>,
+ InterfaceMethod</*desc=*/[{Check if this layout can be achieved by applying a transpose
+ to some other layout according to given permutation of (0...n-1).}],
+ /*retTy=*/"bool",
+ /*methodName=*/"isTransposeOf",
+ /*args=*/(ins "const xegpu::DistributeLayoutAttr&": $other, "ArrayRef<int64_t>": $perm),
+ /*methodBody=*/[{
+ if (!other)
+ return false;
+ if ($_self.getRank() != other.getRank() || perm.size() != static_cast<size_t>($_self.getRank()))
+ return false;
+ // check if the permutation is valid
+ int64_t rank = $_self.getRank();
+ SmallVector<bool, 8> seen(rank, false);
+ for (const auto &ta : llvm::enumerate(perm)) {
+ if (ta.value() < 0 || ta.value() >= rank)
+ return false;
+ if (seen[ta.value()])
+ return false;
+ seen[ta.value()] = true;
+ }
+ auto checkTranspose = [](ArrayRef<int64_t> dst, ArrayRef<int64_t> src, ArrayRef<int64_t> perm) {
+ for (const auto &ta : llvm::enumerate(perm)) {
+ if (src[ta.index()] != dst[ta.value()])
+ return false;
+ }
+ return true;
+ };
+ // check sgLayout
+ if (!checkTranspose($_self.getSgLayoutAsInt(), other.getSgLayoutAsInt(), perm))
+ return false;
+ // check sgData
+ if (!checkTranspose($_self.getSgDataAsInt(), other.getSgDataAsInt(), perm))
+ return false;
+ // check instData
+ if (!checkTranspose($_self.getInstDataAsInt(), other.getInstDataAsInt(), perm))
+ return false;
+ // check laneLayout
+ if (!checkTranspose($_self.getLaneLayoutAsInt(), other.getLaneLayoutAsInt(), perm))
+ return false;
+ // check laneData
+ if (!checkTranspose($_self.getLaneDataAsInt(), other.getLaneDataAsInt(), perm))
+ return false;
+ return true;
+ }]>,
+ InterfaceMethod</*desc=*/[{Check if this layout is a slice of some other layout.}],
+ /*retTy=*/"bool",
+ /*methodName=*/"isSliceOf",
+ /*args=*/(ins "const xegpu::DistributeLayoutAttr&": $other)>
];
}
@@ -433,6 +481,9 @@ def XeGPU_LayoutAttr : XeGPUAttr<"Layout", "layout", [DistributeLayoutAttr]> {
FailureOr<SmallVector<SmallVector<Value>>>
getOffsets(OpBuilder &builder, Location loc, Value linearId, ArrayRef<int64_t> shape);
+ /// Check if this is slice of some other layout.
+ bool isSliceOf(const xegpu::DistributeLayoutAttr &other) { return false; }
+
}];
let assemblyFormat = "`<` struct(params) `>`";
@@ -594,6 +645,9 @@ def XeGPU_SliceAttr : XeGPUAttr<"Slice", "slice", [DistributeLayoutAttr]> {
FailureOr<SmallVector<SmallVector<Value>>>
getOffsets(OpBuilder &builder, Location loc, Value linearId, ArrayRef<int64_t> shape);
+ /// Check if this is slice of some other layout.
+ bool isSliceOf(const xegpu::DistributeLayoutAttr &other);
+
}];
let assemblyFormat = "`<` qualified($parent) `,` `dims` `=` $dims `>`";
diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUDialect.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUDialect.cpp
index 7f3be7f91c56b..cc133b110c95a 100644
--- a/mlir/lib/Dialect/XeGPU/IR/XeGPUDialect.cpp
+++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUDialect.cpp
@@ -14,6 +14,7 @@
#include "mlir/Dialect/XeGPU/IR/XeGPUTargetInfo.h"
#include "mlir/IR/Builders.h"
#include "mlir/IR/DialectImplementation.h"
+#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/TypeSwitch.h"
#include "llvm/Support/Debug.h"
@@ -409,6 +410,26 @@ SliceAttr::getOffsets(OpBuilder &builder, Location loc, Value linearId,
shape);
}
+bool SliceAttr::isSliceOf(const xegpu::DistributeLayoutAttr &other) {
+ auto flattenedThis = flatten();
+ // If other is a LayoutAttr, just compare directly with parent of
+ // flattenedThis.
+ if (auto otherLayout = dyn_cast<xegpu::LayoutAttr>(other))
+ return flattenedThis.getParent() == otherLayout;
+ // If other is a SliceAttr, flatten it first before comparing.
+ auto flattenedOther = dyn_cast<xegpu::SliceAttr>(other).flatten();
+ // Both must have common parent LayoutAttr.
+ if (flattenedThis.getParent() != flattenedOther.getParent())
+ return false;
+ // otherFlattened's sliced dims must be a subset of flattenedThis's sliced
+ // dims.
+ llvm::SmallDenseSet<int64_t> thisDims(
+ flattenedThis.getDims().asArrayRef().begin(),
+ flattenedThis.getDims().asArrayRef().end());
+ return llvm::all_of(flattenedOther.getDims().asArrayRef(),
+ [&](int64_t dim) { return thisDims.contains(dim); });
+}
+
//===----------------------------------------------------------------------===//
// XeGPU_RangeAttr
//===----------------------------------------------------------------------===//
|
/*retTy=*/"bool", | ||
/*methodName=*/"isTransposeOf", | ||
/*args=*/(ins "const xegpu::DistributeLayoutAttr&": $other, "ArrayRef<int64_t>": $perm), | ||
/*methodBody=*/[{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the other PR - nit: could you move it to the source file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adam-smnk , please ignore this PR. changes are already there with #155517
isTransposeOf(DistributedLayoutAttr &other)
: Checks if current is the transpose of other layout.isSliceOf(DistributedLayoutAttr &other)
: Checks is current is a slice of other.