Skip to content

Conversation

cmtice
Copy link
Contributor

@cmtice cmtice commented Sep 10, 2025

PR157951 removed 'REQUIRES: shell' from several tests, which (among other things) caused them to start running on some Windows builders -- the 'REQUIRES: shell' prevented that. Some of those tests fail on Windows. This PR marks those failing tests as UNSUPPORTED on Windows.

PR157951 removed 'REQUIRES: shell' from several tests, which
(among other things) caused them to start running on some
Windows builders -- the 'REQUIRES: shell' prevented that.  Some
of those tests fail on Windows. This PR marks those failing tests
as UNSUPPORTED on Windows.
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (cmtice)

Changes

PR157951 removed 'REQUIRES: shell' from several tests, which (among other things) caused them to start running on some Windows builders -- the 'REQUIRES: shell' prevented that. Some of those tests fail on Windows. This PR marks those failing tests as UNSUPPORTED on Windows.


Full diff: https://github.com/llvm/llvm-project/pull/157972.diff

4 Files Affected:

  • (modified) compiler-rt/test/asan/TestCases/suppressions-library.cpp (+2)
  • (modified) compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp (+2)
  • (modified) compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp (+2)
  • (modified) compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp (+2)
diff --git a/compiler-rt/test/asan/TestCases/suppressions-library.cpp b/compiler-rt/test/asan/TestCases/suppressions-library.cpp
index 9d1f5d4888e39..2da44e1df120b 100644
--- a/compiler-rt/test/asan/TestCases/suppressions-library.cpp
+++ b/compiler-rt/test/asan/TestCases/suppressions-library.cpp
@@ -1,3 +1,5 @@
+// UNSUPPORTED: system-windows
+
 // RUN: %clangxx_asan -O0 -DSHARED_LIB %s %fPIC -shared -o %dynamiclib %ld_flags_rpath_so
 // RUN: %clangxx_asan -O0 %s -o %t %ld_flags_rpath_exe
 
diff --git a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
index 2c094c484371b..53166ccded390 100644
--- a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
+++ b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
@@ -1,3 +1,5 @@
+// UNSUPPORTED: system-windows
+
 // RUN: rm -rf %t-dir && mkdir -p %t-dir
 // RUN: %clangxx_asan %s -o %t-dir/verbose-log-path_test-binary
 
diff --git a/compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp b/compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp
index e1191b5f6bb9c..c6133178262cc 100644
--- a/compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp
+++ b/compiler-rt/test/ubsan/TestCases/Misc/coverage-levels.cpp
@@ -1,5 +1,7 @@
 // Test various levels of coverage
 //
+// UNSUPPORTED: system-windows
+//
 // RUN: rm -rf %t-dir && mkdir %t-dir
 // RUN: %clangxx -fsanitize=shift                        -DGOOD_SHIFT=1 -O1 -fsanitize-coverage=func,trace-pc-guard  %s -o %t
 // RUN: %env_ubsan_opts=coverage=1:verbosity=1:coverage_dir='"%t-dir"' %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1 --check-prefix=CHECK_NOWARN
diff --git a/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp b/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp
index f1618afba248e..4773884cb4cc0 100644
--- a/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp
+++ b/compiler-rt/test/ubsan/TestCases/Misc/log-path_test.cpp
@@ -1,3 +1,5 @@
+// UNSUPPORTED: system-windows
+
 // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
 // XFAIL: android
 

@cmtice cmtice merged commit 6a63114 into llvm:main Sep 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants