Fix a -Wunused-variable warning on windows
#157973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `UID` variable is only being used inside the `#ifndef _WIN32` block - move the definition into the block as well.
llvm-beanz
approved these changes
Sep 10, 2025
hekota
approved these changes
Sep 11, 2025
|
@llvm/pr-subscribers-llvm-support Author: Justin Bogner (bogner) ChangesThe Full diff: https://github.com/llvm/llvm-project/pull/157973.diff 1 Files Affected:
diff --git a/llvm/unittests/Support/VirtualOutputBackendsTest.cpp b/llvm/unittests/Support/VirtualOutputBackendsTest.cpp
index 3aee880a377df..03a4a9c3c7c32 100644
--- a/llvm/unittests/Support/VirtualOutputBackendsTest.cpp
+++ b/llvm/unittests/Support/VirtualOutputBackendsTest.cpp
@@ -559,9 +559,9 @@ Error OnDiskOutputBackendProvider::checkKept(StringRef FilePath,
if (Error E = lookupFileInfo(FilePath, Info))
return E;
+#ifndef _WIN32
sys::fs::UniqueID UID =
shouldUseTemporaries(*Info) ? *Info->TempUID : *Info->UID;
-#ifndef _WIN32
if (!Info->F->hasUniqueID(UID))
return createStringError(inconvertibleErrorCode(),
"File not created by keep or changed UID");
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/22470 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UIDvariable is only being used inside the#ifndef _WIN32block - move the definition into the block as well.